| Message ID | 20230112163905.73065-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 83b9e0fc9ed6129aeb1ac18bee85f17fa32e91e2 |
| Headers | show |
| Series | [v1,1/1] gpio: ge: Remove duplicate assignment of of_gpio_n_cells | expand |
On Thu, Jan 12, 2023 at 5:38 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > The of_gpio_n_cells default is 2 when ->of_xlate() callback is > not defined. No need to assign it explicitly in the driver. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/gpio/gpio-ge.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpio/gpio-ge.c b/drivers/gpio/gpio-ge.c > index f6a3de99f7db..7bd4c2a4cc11 100644 > --- a/drivers/gpio/gpio-ge.c > +++ b/drivers/gpio/gpio-ge.c > @@ -81,7 +81,6 @@ static int __init gef_gpio_probe(struct platform_device *pdev) > > gc->base = -1; > gc->ngpio = (u16)(uintptr_t)of_device_get_match_data(&pdev->dev); > - gc->of_gpio_n_cells = 2; > > /* This function adds a memory mapped GPIO chip */ > ret = devm_gpiochip_add_data(&pdev->dev, gc, NULL); > -- > 2.39.0 > Applied, thanks! Bart
diff --git a/drivers/gpio/gpio-ge.c b/drivers/gpio/gpio-ge.c index f6a3de99f7db..7bd4c2a4cc11 100644 --- a/drivers/gpio/gpio-ge.c +++ b/drivers/gpio/gpio-ge.c @@ -81,7 +81,6 @@ static int __init gef_gpio_probe(struct platform_device *pdev) gc->base = -1; gc->ngpio = (u16)(uintptr_t)of_device_get_match_data(&pdev->dev); - gc->of_gpio_n_cells = 2; /* This function adds a memory mapped GPIO chip */ ret = devm_gpiochip_add_data(&pdev->dev, gc, NULL);
The of_gpio_n_cells default is 2 when ->of_xlate() callback is not defined. No need to assign it explicitly in the driver. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpio-ge.c | 1 - 1 file changed, 1 deletion(-)