| Message ID | 20230112163855.73032-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | e226cb199c3d5bde57a4439cdc0360d900270816 |
| Headers | show |
| Series | [v1,1/1] gpio: davinci: Remove duplicate assignment of of_gpio_n_cells | expand |
On Thu, Jan 12, 2023 at 5:38 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > The of_gpio_n_cells default is 2 when ->of_xlate() callback is > not defined. No need to assign it explicitly in the driver. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/gpio/gpio-davinci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c > index e1c1b9a527db..26b1f7465e09 100644 > --- a/drivers/gpio/gpio-davinci.c > +++ b/drivers/gpio/gpio-davinci.c > @@ -252,7 +252,6 @@ static int davinci_gpio_probe(struct platform_device *pdev) > chips->chip.base = pdata->no_auto_base ? pdata->base : -1; > > #ifdef CONFIG_OF_GPIO > - chips->chip.of_gpio_n_cells = 2; > chips->chip.parent = dev; > chips->chip.request = gpiochip_generic_request; > chips->chip.free = gpiochip_generic_free; > -- > 2.39.0 > Applied, thanks! Bart
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index e1c1b9a527db..26b1f7465e09 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -252,7 +252,6 @@ static int davinci_gpio_probe(struct platform_device *pdev) chips->chip.base = pdata->no_auto_base ? pdata->base : -1; #ifdef CONFIG_OF_GPIO - chips->chip.of_gpio_n_cells = 2; chips->chip.parent = dev; chips->chip.request = gpiochip_generic_request; chips->chip.free = gpiochip_generic_free;
The of_gpio_n_cells default is 2 when ->of_xlate() callback is not defined. No need to assign it explicitly in the driver. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpio-davinci.c | 1 - 1 file changed, 1 deletion(-)