| Message ID | 20230109132719.86009-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 091e81b867796130a08be162ff8d9332492de26e |
| Headers | show |
| Series | [v1,1/1] pinctrl: pinmux: Drop duplicate error message in pinmux_select() | expand |
On Mon, Jan 9, 2023 at 2:26 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > pinctrl_get_group_selector() prints an error message when group > is not found in the list. No need to repeat this in the caller. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 6bd7ac37a0e0..021382632608 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -744,10 +744,8 @@ static ssize_t pinmux_select(struct file *file, const char __user *user_buf, } ret = pinctrl_get_group_selector(pctldev, gname); - if (ret < 0) { - dev_err(pctldev->dev, "failed to get group selector for %s", gname); + if (ret < 0) goto exit_free_buf; - } gsel = ret; ret = pmxops->set_mux(pctldev, fsel, gsel);
pinctrl_get_group_selector() prints an error message when group is not found in the list. No need to repeat this in the caller. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/pinmux.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)