diff mbox

[v2] ARM: rockchip: Fix use of plain integer as NULL pointer

Message ID 1458222191-26023-1-git-send-email-peter.griffin@linaro.org
State Accepted
Commit 26d5192953d88d6231d173281848a1c61f9e5d34
Headers show

Commit Message

Peter Griffin March 17, 2016, 1:43 p.m. UTC
This fixes the following sparse build warning:

     mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>

---
 arch/arm/mach-rockchip/platsmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

Comments

Peter Griffin March 17, 2016, 2:04 p.m. UTC | #1
Hi Heiko,

On Thu, 17 Mar 2016, Heiko Stübner wrote:

> Hi Peter,

> 

> no need to resend for that (will be lost when applying anyway), but for future 

> patches please consider the things below:

> 

> Am Donnerstag, 17. März 2016, 13:43:11 schrieb Peter Griffin:

> > This fixes the following sparse build warning:

> > 

> >      mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer

> > 

> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>

> 

> please bring aling tags received in previous versions to future ones, like the 

> one from Lee:

> 

> Acked-by: Lee Jones <lee.jones@linaro.org>


Will do, I didn't notice Lee had also Acked it. I should have been paying more
attention and not re-spinning whilst in a conf call.
> 

> > ---

> 

> changes in v2:

> - beautify commit message

> 

> 

> otherwise, patch looks nice and I'll pick it up shortly

> 

> 

> Thanks for catching this


No problem, thanks for the feedback and taking the patch.

regards,

Peter.
diff mbox

Patch

diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
index d42a07e..4d827a0 100644
--- a/arch/arm/mach-rockchip/platsmp.c
+++ b/arch/arm/mach-rockchip/platsmp.c
@@ -65,7 +65,7 @@  static struct reset_control *rockchip_get_core_reset(int cpu)
 	if (dev)
 		np = dev->of_node;
 	else
-		np = of_get_cpu_node(cpu, 0);
+		np = of_get_cpu_node(cpu, NULL);
 
 	return of_reset_control_get(np, NULL);
 }