diff mbox

qemu: Don't overwrite DomainSave errors

Message ID db06c834a31e56cb56f33b06e0b207dbbef18a7b.1458069884.git.crobinso@redhat.com
State Accepted
Commit 26f3d9c26ccc8e380ef9e1e9a8df51aa7c2387d2
Headers show

Commit Message

Cole Robinson March 15, 2016, 7:24 p.m. UTC 
These functions already report fine grained errors, there's no
benefit to overwriting the error here.
---
 src/qemu/qemu_driver.c | 4 ----
 1 file changed, 4 deletions(-)

-- 
2.5.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Cole Robinson March 15, 2016, 7:45 p.m. UTC | #1 
On 03/15/2016 03:35 PM, Pavel Hrdina wrote:
> On Tue, Mar 15, 2016 at 03:24:44PM -0400, Cole Robinson wrote:

>> These functions already report fine grained errors, there's no

>> benefit to overwriting the error here.

>> ---

>>  src/qemu/qemu_driver.c | 4 ----

>>  1 file changed, 4 deletions(-)

> 

> ACK

> 

> Pavel

> 


Thanks, pushed (with the syntax-check warning fixed :/ )

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
diff mbox

Patch

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index edf39d9..36c8fb5 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -17632,8 +17632,6 @@  qemuDomainSetBlockIoTune(virDomainPtr dom,
 
         ret = virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps);
         if (ret < 0) {
-            virReportError(VIR_ERR_OPERATION_FAILED, "%s",
-                           _("Saving live XML config failed"));
             goto endjob;
         }
 
@@ -17659,8 +17657,6 @@  qemuDomainSetBlockIoTune(virDomainPtr dom,
         conf_disk->blkdeviotune = info;
         ret = virDomainSaveConfig(cfg->configDir, driver->caps, persistentDef);
         if (ret < 0) {
-            virReportError(VIR_ERR_OPERATION_INVALID, "%s",
-                           _("Write to config file failed"));
             goto endjob;
         }
     }