| Message ID | 20221223132213.81273-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | 1135e93682db5f66909f4785b1bfbd798955b2b1 |
| Headers | show |
| Series | dt-bindings: remoteproc: qcom,glink-edge: add GPR node | expand |
On Fri, 23 Dec 2022 14:22:13 +0100, Krzysztof Kozlowski wrote: > The existing SM8450 DTS (and newer platforms) come with a "gpr" child node, > not "apr": > > sm8450-sony-xperia-nagara-pdx224.dtb: remoteproc@30000000: glink-edge: Unevaluated properties are not allowed ('gpr' was unexpected) > From schema: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/remoteproc/qcom,glink-edge.yaml | 24 ++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Fri, 23 Dec 2022 14:22:13 +0100, Krzysztof Kozlowski wrote: > The existing SM8450 DTS (and newer platforms) come with a "gpr" child node, > not "apr": > > sm8450-sony-xperia-nagara-pdx224.dtb: remoteproc@30000000: glink-edge: Unevaluated properties are not allowed ('gpr' was unexpected) > From schema: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml > > > [...] Applied, thanks! [1/1] dt-bindings: remoteproc: qcom,glink-edge: add GPR node commit: 1135e93682db5f66909f4785b1bfbd798955b2b1 Best regards,
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml index 25c27464ef25..8e133ab55ff3 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml @@ -22,7 +22,7 @@ properties: required: - qcom,glink-channels description: - Qualcomm APR/GPR (Asynchronous/Generic Packet Router) + Qualcomm APR (Asynchronous Packet Router) fastrpc: $ref: /schemas/misc/qcom,fastrpc.yaml# @@ -31,6 +31,13 @@ properties: description: Qualcomm FastRPC + gpr: + $ref: /schemas/soc/qcom/qcom,apr.yaml# + required: + - qcom,glink-channels + description: + Qualcomm GPR (Generic Packet Router) + interrupts: maxItems: 1 @@ -52,6 +59,21 @@ required: - mboxes - qcom,remote-pid +allOf: + - if: + required: + - apr + then: + properties: + gpr: false + + - if: + required: + - gpr + then: + properties: + apr: false + additionalProperties: false examples:
The existing SM8450 DTS (and newer platforms) come with a "gpr" child node, not "apr": sm8450-sony-xperia-nagara-pdx224.dtb: remoteproc@30000000: glink-edge: Unevaluated properties are not allowed ('gpr' was unexpected) From schema: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/remoteproc/qcom,glink-edge.yaml | 24 ++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-)