| Message ID | 20221225115844.55126-2-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/4] ARM: dts: qcom: align OPP table node name with DT schema | expand |
On 25.12.2022 12:58, Krzysztof Kozlowski wrote: > Bindings expect OPP tables to start with "opp-table". > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sa8540p.dtsi | 4 ++-- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 6 +++--- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > 4 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi > index 5728583af41e..929bdcd45d02 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi > @@ -19,7 +19,7 @@ / { > * features get enabled upstream. > */ > > -gpu_opp_table_3_0: gpu-opp-table-30 { > +gpu_opp_table_3_0: opp-table-gpu30 { > compatible = "operating-points-v2"; > > opp-624000000 { > diff --git a/arch/arm64/boot/dts/qcom/sa8540p.dtsi b/arch/arm64/boot/dts/qcom/sa8540p.dtsi > index a88452c20d05..4a990fda8fc3 100644 > --- a/arch/arm64/boot/dts/qcom/sa8540p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8540p.dtsi > @@ -10,7 +10,7 @@ > /delete-node/ &cpu4_opp_table; > > / { > - cpu0_opp_table: cpu0-opp-table { > + cpu0_opp_table: opp-table-cpu0 { > compatible = "operating-points-v2"; > opp-shared; > > @@ -92,7 +92,7 @@ opp-2246400000 { > }; > }; > > - cpu4_opp_table: cpu4-opp-table { > + cpu4_opp_table: opp-table-cpu4 { > compatible = "operating-points-v2"; > opp-shared; > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 109c9d2b684d..89004cb657e0 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -33,7 +33,7 @@ sleep_clk: sleep-clk { > }; > }; > > - cpu0_opp_table: cpu0-opp-table { > + cpu0_opp_table: opp-table-cpu0 { > compatible = "operating-points-v2"; > opp-shared; > > @@ -123,7 +123,7 @@ opp-2438400000 { > }; > }; > > - cpu4_opp_table: cpu4-opp-table { > + cpu4_opp_table: opp-table-cpu4 { > compatible = "operating-points-v2"; > opp-shared; > > @@ -591,7 +591,7 @@ CLUSTER_PD: cpu-cluster0 { > }; > }; > > - qup_opp_table_100mhz: qup-100mhz-opp-table { > + qup_opp_table_100mhz: opp-table-qup100mhz { > compatible = "operating-points-v2"; > > opp-75000000 { > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 65032b94b46d..ba48adc01170 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -4619,7 +4619,7 @@ port@1 { > }; > }; > > - dp_opp_table: dp-opp-table { > + dp_opp_table: opp-table { > compatible = "operating-points-v2"; > > opp-162000000 {
On Sun, Dec 25, 2022 at 12:58:42PM +0100, Krzysztof Kozlowski wrote: > Bindings expect OPP tables to start with "opp-table". > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sa8540p.dtsi | 4 ++-- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 6 +++--- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > 4 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi > index 5728583af41e..929bdcd45d02 100644 > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 109c9d2b684d..89004cb657e0 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -33,7 +33,7 @@ sleep_clk: sleep-clk { > }; > }; > > - cpu0_opp_table: cpu0-opp-table { > + cpu0_opp_table: opp-table-cpu0 { > compatible = "operating-points-v2"; > opp-shared; > > @@ -123,7 +123,7 @@ opp-2438400000 { > }; > }; > > - cpu4_opp_table: cpu4-opp-table { > + cpu4_opp_table: opp-table-cpu4 { > compatible = "operating-points-v2"; > opp-shared; > > @@ -591,7 +591,7 @@ CLUSTER_PD: cpu-cluster0 { > }; > }; > > - qup_opp_table_100mhz: qup-100mhz-opp-table { > + qup_opp_table_100mhz: opp-table-qup100mhz { > compatible = "operating-points-v2"; > > opp-75000000 { Please also move these nodes after the 'memory' node so that they remain sorted by name. Johan
On 27/12/2022 18:17, Johan Hovold wrote: > On Sun, Dec 25, 2022 at 12:58:42PM +0100, Krzysztof Kozlowski wrote: >> Bindings expect OPP tables to start with "opp-table". >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi | 2 +- >> arch/arm64/boot/dts/qcom/sa8540p.dtsi | 4 ++-- >> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 6 +++--- >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- >> 4 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi >> index 5728583af41e..929bdcd45d02 100644 > >> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >> index 109c9d2b684d..89004cb657e0 100644 >> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >> @@ -33,7 +33,7 @@ sleep_clk: sleep-clk { >> }; >> }; >> >> - cpu0_opp_table: cpu0-opp-table { >> + cpu0_opp_table: opp-table-cpu0 { >> compatible = "operating-points-v2"; >> opp-shared; >> >> @@ -123,7 +123,7 @@ opp-2438400000 { >> }; >> }; >> >> - cpu4_opp_table: cpu4-opp-table { >> + cpu4_opp_table: opp-table-cpu4 { >> compatible = "operating-points-v2"; >> opp-shared; >> >> @@ -591,7 +591,7 @@ CLUSTER_PD: cpu-cluster0 { >> }; >> }; >> >> - qup_opp_table_100mhz: qup-100mhz-opp-table { >> + qup_opp_table_100mhz: opp-table-qup100mhz { >> compatible = "operating-points-v2"; >> >> opp-75000000 { > > Please also move these nodes after the 'memory' node so that they remain > sorted by name. OK Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi index 5728583af41e..929bdcd45d02 100644 --- a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi @@ -19,7 +19,7 @@ / { * features get enabled upstream. */ -gpu_opp_table_3_0: gpu-opp-table-30 { +gpu_opp_table_3_0: opp-table-gpu30 { compatible = "operating-points-v2"; opp-624000000 { diff --git a/arch/arm64/boot/dts/qcom/sa8540p.dtsi b/arch/arm64/boot/dts/qcom/sa8540p.dtsi index a88452c20d05..4a990fda8fc3 100644 --- a/arch/arm64/boot/dts/qcom/sa8540p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8540p.dtsi @@ -10,7 +10,7 @@ /delete-node/ &cpu4_opp_table; / { - cpu0_opp_table: cpu0-opp-table { + cpu0_opp_table: opp-table-cpu0 { compatible = "operating-points-v2"; opp-shared; @@ -92,7 +92,7 @@ opp-2246400000 { }; }; - cpu4_opp_table: cpu4-opp-table { + cpu4_opp_table: opp-table-cpu4 { compatible = "operating-points-v2"; opp-shared; diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index 109c9d2b684d..89004cb657e0 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -33,7 +33,7 @@ sleep_clk: sleep-clk { }; }; - cpu0_opp_table: cpu0-opp-table { + cpu0_opp_table: opp-table-cpu0 { compatible = "operating-points-v2"; opp-shared; @@ -123,7 +123,7 @@ opp-2438400000 { }; }; - cpu4_opp_table: cpu4-opp-table { + cpu4_opp_table: opp-table-cpu4 { compatible = "operating-points-v2"; opp-shared; @@ -591,7 +591,7 @@ CLUSTER_PD: cpu-cluster0 { }; }; - qup_opp_table_100mhz: qup-100mhz-opp-table { + qup_opp_table_100mhz: opp-table-qup100mhz { compatible = "operating-points-v2"; opp-75000000 { diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 65032b94b46d..ba48adc01170 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -4619,7 +4619,7 @@ port@1 { }; }; - dp_opp_table: dp-opp-table { + dp_opp_table: opp-table { compatible = "operating-points-v2"; opp-162000000 {
Bindings expect OPP tables to start with "opp-table". Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi | 2 +- arch/arm64/boot/dts/qcom/sa8540p.dtsi | 4 ++-- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 6 +++--- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-)