diff mbox series

Bluetooth: hci_sync: Fix use HCI_OP_LE_READ_BUFFER_SIZE_V2

Message ID 20221219213747.3659867-1-luiz.dentz@gmail.com
State New
Headers show
Series Bluetooth: hci_sync: Fix use HCI_OP_LE_READ_BUFFER_SIZE_V2 | expand

Commit Message

Luiz Augusto von Dentz Dec. 19, 2022, 9:37 p.m. UTC 
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

Don't try to use HCI_OP_LE_READ_BUFFER_SIZE_V2 if controller don't
support ISO channels.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216817
Fixes: c1631dbc00c1 ("Bluetooth: hci_sync: Fix hci_read_buffer_size_sync")
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com Dec. 19, 2022, 10:33 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=705742

---Test result---

Test Summary:
CheckPatch                    PASS      3.22 seconds
GitLint                       PASS      0.42 seconds
SubjectPrefix                 PASS      0.11 seconds
BuildKernel                   PASS      40.47 seconds
CheckAllWarning               PASS      41.57 seconds
CheckSparse                   PASS      46.16 seconds
BuildKernel32                 PASS      36.23 seconds
TestRunnerSetup               PASS      519.98 seconds
TestRunner_l2cap-tester       PASS      19.26 seconds
TestRunner_iso-tester         FAIL      20.55 seconds
TestRunner_bnep-tester        PASS      6.68 seconds
TestRunner_mgmt-tester        PASS      123.47 seconds
TestRunner_rfcomm-tester      PASS      10.35 seconds
TestRunner_sco-tester         PASS      9.39 seconds
TestRunner_ioctl-tester       PASS      11.23 seconds
TestRunner_mesh-tester        PASS      8.27 seconds
TestRunner_smp-tester         PASS      9.32 seconds
TestRunner_userchan-tester    PASS      7.04 seconds
IncrementalBuild              PASS      34.46 seconds

Details
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 56, Passed: 49 (87.5%), Failed: 7, Not Run: 0

Failed Test Cases
ISO Send - Success                                   Failed       0.293 seconds
ISO Defer Send - Success                             Failed       0.288 seconds
ISO 48_2_1 Defer Send - Success                      Failed       0.293 seconds
ISO Send and Receive - Success                       Failed       0.290 seconds
ISO Broadcaster - Success                            Failed       0.270 seconds
ISO Broadcaster BIG 0x01 - Success                   Failed       0.261 seconds
ISO Broadcaster BIG 0x01 BIS 0x01 - Success          Failed       0.261 seconds


---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 5220bfd75b00..b3676b899647 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -3572,7 +3572,7 @@  static const struct hci_init_stage hci_init2[] = {
 static int hci_le_read_buffer_size_sync(struct hci_dev *hdev)
 {
 	/* Use Read LE Buffer Size V2 if supported */
-	if (hdev->commands[41] & 0x20)
+	if (iso_capable(hdev) && hdev->commands[41] & 0x20)
 		return __hci_cmd_sync_status(hdev,
 					     HCI_OP_LE_READ_BUFFER_SIZE_V2,
 					     0, NULL, HCI_CMD_TIMEOUT);