| Message ID | 87sfhipynv.wl-kuninori.morimoto.gx@renesas.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: dt-bindings: audio-graph-port related update | expand |
On Wed, Dec 14, 2022 at 01:22:13AM +0000, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Audio Graph user needs "ports" not only "port". > This patch adds new "ports" on audio-graph-port to use it easily. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > .../devicetree/bindings/sound/audio-graph-port.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml > index 56d47dcab490..273da5a76b8a 100644 > --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml > +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml > @@ -97,6 +97,18 @@ definitions: > minimum: 1 > maximum: 64 > > + ports: > + $ref: "#/definitions/port-base" > + unevaluatedProperties: false > + patternProperties: > + "^port(@[0-9a-f]+)?$": > + $ref: "#/definitions/port-base" > + unevaluatedProperties: false > + patternProperties: > + "^endpoint(@[0-9a-f]+)?": > + $ref: "#/definitions/endpoint-base" > + unevaluatedProperties: false > + This won't work because any user that uses 'ports' here cannot add any properties to port or endpoint nodes which I thought was the point of this series. Rob
Hi Rob > > + ports: > > + $ref: "#/definitions/port-base" > > + unevaluatedProperties: false > > + patternProperties: > > + "^port(@[0-9a-f]+)?$": > > + $ref: "#/definitions/port-base" > > + unevaluatedProperties: false > > + patternProperties: > > + "^endpoint(@[0-9a-f]+)?": > > + $ref: "#/definitions/endpoint-base" > > + unevaluatedProperties: false > > + > > This won't work because any user that uses 'ports' here cannot add any > properties to port or endpoint nodes which I thought was the point of > this series. Now, we have port-base/endpoint-base on definitions. The user who want to have own properties can reuse it and redefine. The user who don't use own properties can use above "ports" which is implemented under "definitions". It is for very standard "ports". By having standard "ports" under "definitions", we can avoid duplicate "ports" IMO. Thank you for your help !! Best regards --- Kuninori Morimoto
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml index 56d47dcab490..273da5a76b8a 100644 --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml @@ -97,6 +97,18 @@ definitions: minimum: 1 maximum: 64 + ports: + $ref: "#/definitions/port-base" + unevaluatedProperties: false + patternProperties: + "^port(@[0-9a-f]+)?$": + $ref: "#/definitions/port-base" + unevaluatedProperties: false + patternProperties: + "^endpoint(@[0-9a-f]+)?": + $ref: "#/definitions/endpoint-base" + unevaluatedProperties: false + allOf: - $ref: "#/definitions/port-base"