diff mbox series

[1/4] media: ti/davinci: vpbe_osd: Drop empty platform remove function

Message ID 20221213153553.648871-2-u.kleine-koenig@pengutronix.de
State Accepted
Commit eb78ca6a0496795f3abf16fe64b8450ef0639195
Headers show
Series media: Drop empty platform remove functions | expand

Commit Message

Uwe Kleine-König Dec. 13, 2022, 3:35 p.m. UTC 
A remove callback just returning 0 is equivalent to no remove callback
at all. So drop the useless function.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/media/platform/ti/davinci/vpbe_osd.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Lad, Prabhakar Jan. 12, 2023, 10:52 p.m. UTC | #1 
On Tue, Dec 13, 2022 at 3:36 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> A remove callback just returning 0 is equivalent to no remove callback
> at all. So drop the useless function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/media/platform/ti/davinci/vpbe_osd.c | 6 ------
>  1 file changed, 6 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
Prabhakar

> diff --git a/drivers/media/platform/ti/davinci/vpbe_osd.c b/drivers/media/platform/ti/davinci/vpbe_osd.c
> index 32f7ef547c82..f6ea71c081d4 100644
> --- a/drivers/media/platform/ti/davinci/vpbe_osd.c
> +++ b/drivers/media/platform/ti/davinci/vpbe_osd.c
> @@ -1561,14 +1561,8 @@ static int osd_probe(struct platform_device *pdev)
>         return 0;
>  }
>
> -static int osd_remove(struct platform_device *pdev)
> -{
> -       return 0;
> -}
> -
>  static struct platform_driver osd_driver = {
>         .probe          = osd_probe,
> -       .remove         = osd_remove,
>         .driver         = {
>                 .name   = MODULE_NAME,
>         },
> --
> 2.38.1
>
diff mbox series

Patch

diff --git a/drivers/media/platform/ti/davinci/vpbe_osd.c b/drivers/media/platform/ti/davinci/vpbe_osd.c
index 32f7ef547c82..f6ea71c081d4 100644
--- a/drivers/media/platform/ti/davinci/vpbe_osd.c
+++ b/drivers/media/platform/ti/davinci/vpbe_osd.c
@@ -1561,14 +1561,8 @@  static int osd_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int osd_remove(struct platform_device *pdev)
-{
-	return 0;
-}
-
 static struct platform_driver osd_driver = {
 	.probe		= osd_probe,
-	.remove		= osd_remove,
 	.driver		= {
 		.name	= MODULE_NAME,
 	},