| Message ID | 20221213182125.929303-1-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Accepted |
| Commit | b7f44e1249cc2831600802bd43474c75f75a9e0c |
| Headers | show |
| Series | pinctrl: da850-pupd: Drop empty platform remove function | expand |
On Tue, Dec 13, 2022 at 7:21 PM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > A remove callback just returning 0 is equivalent to no remove callback > at all. So drop the useless function. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-da850-pupd.c b/drivers/pinctrl/pinctrl-da850-pupd.c index 5a0a1f20c843..5eb248663e17 100644 --- a/drivers/pinctrl/pinctrl-da850-pupd.c +++ b/drivers/pinctrl/pinctrl-da850-pupd.c @@ -173,11 +173,6 @@ static int da850_pupd_probe(struct platform_device *pdev) return 0; } -static int da850_pupd_remove(struct platform_device *pdev) -{ - return 0; -} - static const struct of_device_id da850_pupd_of_match[] = { { .compatible = "ti,da850-pupd" }, { } @@ -190,7 +185,6 @@ static struct platform_driver da850_pupd_driver = { .of_match_table = da850_pupd_of_match, }, .probe = da850_pupd_probe, - .remove = da850_pupd_remove, }; module_platform_driver(da850_pupd_driver);
A remove callback just returning 0 is equivalent to no remove callback at all. So drop the useless function. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/pinctrl/pinctrl-da850-pupd.c | 6 ------ 1 file changed, 6 deletions(-) base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476