| Message ID | 20221209155623.29147-4-biju.das.jz@bp.renesas.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add Polling support for role detection with HD3SS3220 | expand |
Hi Greg, On Fri, Dec 9, 2022 at 5:16 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Fri, Dec 09, 2022 at 03:56:22PM +0000, Biju Das wrote: > > This patch sorts the header files alphabetically. > > This says what you are doing, but not why. > > Why is this needed? What does this fix? This is no requirement of USB > code that I know of. ... to avoid merge conflicts when adding/removing includes in future patches. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, Dec 15, 2022 at 11:05:13AM +0100, Geert Uytterhoeven wrote: > Hi Greg, > > On Fri, Dec 9, 2022 at 5:16 PM Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > On Fri, Dec 09, 2022 at 03:56:22PM +0000, Biju Das wrote: > > > This patch sorts the header files alphabetically. > > > > This says what you are doing, but not why. > > > > Why is this needed? What does this fix? This is no requirement of USB > > code that I know of. > > ... to avoid merge conflicts when adding/removing includes in future > patches. Then let's deal with that then, again, this isn't a real issue, sorry. greg k-h
diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c index c24bbccd14f9..666a93f7ec65 100644 --- a/drivers/usb/typec/hd3ss3220.c +++ b/drivers/usb/typec/hd3ss3220.c @@ -5,15 +5,15 @@ * Copyright (C) 2019 Renesas Electronics Corp. */ -#include <linux/module.h> +#include <linux/delay.h> #include <linux/i2c.h> -#include <linux/usb/role.h> -#include <linux/irqreturn.h> #include <linux/interrupt.h> +#include <linux/irqreturn.h> +#include <linux/module.h> #include <linux/regmap.h> #include <linux/slab.h> +#include <linux/usb/role.h> #include <linux/usb/typec.h> -#include <linux/delay.h> #define HD3SS3220_REG_CN_STAT_CTRL 0x09 #define HD3SS3220_REG_GEN_CTRL 0x0A
This patch sorts the header files alphabetically. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- drivers/usb/typec/hd3ss3220.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)