diff mbox

[edk2,3/3] ArmPlatformPkg/PL180MciDxe: don't check ID_REG3

Message ID 1456853207-937-4-git-send-email-ryan.harkin@linaro.org
State Accepted
Commit d777442bb4f801e58da2bea4c43a8c29cef09057
Headers show

Commit Message

Ryan Harkin March 1, 2016, 5:26 p.m. UTC 
TC2 reads 0x02 for the PL180 ID3 register instead of 0x00 as defined in
the spec.

However, the spec [1] states that the contents of ID3 register represent
the "configuration option of the peripheral" and thus not part of the
Prime Cell identification.

For this patch, we drop checking the value in MCI_PERIPH_ID_REG3.

[1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0172a/index.html

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>

---
 ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.5.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox

Patch

diff --git a/ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c b/ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c
index 3e94ea5..5526aac 100644
--- a/ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c
+++ b/ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c
@@ -528,7 +528,6 @@  PL180MciDxeInitialize (
   if (MmioRead8 (MCI_PERIPH_ID_REG0) != MCI_PERIPH_ID0 ||
       MmioRead8 (MCI_PERIPH_ID_REG1) != MCI_PERIPH_ID1 ||
       MmioRead8 (MCI_PERIPH_ID_REG2) != MCI_PERIPH_ID2 ||
-      MmioRead8 (MCI_PERIPH_ID_REG3) != MCI_PERIPH_ID3 ||
       MmioRead8 (MCI_PCELL_ID_REG0)  != MCI_PCELL_ID0  ||
       MmioRead8 (MCI_PCELL_ID_REG1)  != MCI_PCELL_ID1  ||
       MmioRead8 (MCI_PCELL_ID_REG2)  != MCI_PCELL_ID2  ||