| Message ID | 20221211205124.23823-2-marex@denx.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | None | expand |
Hi, On Sun, Dec 11, 2022 at 09:51:24PM +0100, Marek Vasut wrote: > The clock {} subnode seems like it is describing an always-on clock > generated by the PMIC. This should rather be modeled by consumer of > the clock taking phandle to the RTC node itself, since it already > does have clock-cells and all. Since there are no users of the clock > subnode in tree anyway, mark it as deprecated to avoid proliferation > of this approach. > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Alessandro Zummo <a.zummo@towertech.it> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: linux-rtc@vger.kernel.org > To: devicetree@vger.kernel.org > --- > V2: - Add AB from Krzysztof > V3: - No change > --- I just noticed this by accident. Basically everything in the patch description is wrong: 1. There is a in-tree user: arch/arm/boot/dts/imx6dl-qmx6.dtsi 2. The PMIC has nothing to do with this 3. Directly referencing the RTC does not work, since that introduces an unsolvable dependency loop on QMX6. This was the solution accepted by Rob and Saravana: [v1] https://lore.kernel.org/lkml/20210222171247.97609-1-sebastian.reichel@collabora.com/ [v2] https://lore.kernel.org/all/20210428222953.235280-1-sebastian.reichel@collabora.com/ -- Sebastian > Documentation/devicetree/bindings/rtc/st,m41t80.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/rtc/st,m41t80.yaml b/Documentation/devicetree/bindings/rtc/st,m41t80.yaml > index fc9c6da6483f5..03ff833f5fe9d 100644 > --- a/Documentation/devicetree/bindings/rtc/st,m41t80.yaml > +++ b/Documentation/devicetree/bindings/rtc/st,m41t80.yaml > @@ -40,6 +40,7 @@ properties: > clock: > type: object > $ref: /schemas/clock/fixed-clock.yaml# > + deprecated: true > properties: > clock-frequency: > const: 32768 > -- > 2.35.1 >
diff --git a/Documentation/devicetree/bindings/rtc/st,m41t80.yaml b/Documentation/devicetree/bindings/rtc/st,m41t80.yaml index fc9c6da6483f5..03ff833f5fe9d 100644 --- a/Documentation/devicetree/bindings/rtc/st,m41t80.yaml +++ b/Documentation/devicetree/bindings/rtc/st,m41t80.yaml @@ -40,6 +40,7 @@ properties: clock: type: object $ref: /schemas/clock/fixed-clock.yaml# + deprecated: true properties: clock-frequency: const: 32768
The clock {} subnode seems like it is describing an always-on clock generated by the PMIC. This should rather be modeled by consumer of the clock taking phandle to the RTC node itself, since it already does have clock-cells and all. Since there are no users of the clock subnode in tree anyway, mark it as deprecated to avoid proliferation of this approach. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Alessandro Zummo <a.zummo@towertech.it> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: linux-rtc@vger.kernel.org To: devicetree@vger.kernel.org --- V2: - Add AB from Krzysztof V3: - No change --- Documentation/devicetree/bindings/rtc/st,m41t80.yaml | 1 + 1 file changed, 1 insertion(+)