| Message ID | 20221208094519.3561610-1-alexander.stein@ew.tq-group.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/1] dt-bindings: lcdif: Fix constraints for imx8mp | expand |
On 08/12/2022 10:45, Alexander Stein wrote: > i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names. > This SoC requires a power-domain for this peripheral to use. Add it as > a required property. > > Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > Changes in v2: > * Squash both patches into one > * Split the conditionals from fsl,imx6sx-lcdif > * Mark power-domains as required for fsl,imx8mp-lcdif > * Ignored the A-b & R-b due to reorganization > > I'm not sure if this is the best way to add the constraints. I noticed that > imx6sx also uses a power-domain, but imx6ul which is compatible to imx6sx does > not, so they can't be merged. > > I also have noticed that dtbs_check doesn't raise a warning when > power-domains is actually missing. > > .../bindings/display/fsl,lcdif.yaml | 31 ++++++++++++++++++- > 1 file changed, 30 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 876015a44a1e6..24014651f7dc8 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -52,6 +52,9 @@ properties: > interrupts: > maxItems: 1 > > + power-domains: > + maxItems: 1 > + > port: > $ref: /schemas/graph.yaml#/properties/port > description: The LCDIF output port > @@ -81,7 +84,33 @@ allOf: > maxItems: 3 > required: > - clock-names > - else: > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8mp-lcdif > + then: > + properties: > + clocks: > + minItems: 3 > + maxItems: 3 > + clock-names: > + minItems: 3 > + maxItems: 3 > + power-domains: > + minItems: 1 Drop power domains here. > + required: > + - clock-names > + - power-domains > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx6sx-lcdif > + - fsl,imx8mp-lcdif > + then: > properties: > clocks: > maxItems: 1 Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index 876015a44a1e6..24014651f7dc8 100644 --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml @@ -52,6 +52,9 @@ properties: interrupts: maxItems: 1 + power-domains: + maxItems: 1 + port: $ref: /schemas/graph.yaml#/properties/port description: The LCDIF output port @@ -81,7 +84,33 @@ allOf: maxItems: 3 required: - clock-names - else: + - if: + properties: + compatible: + contains: + const: fsl,imx8mp-lcdif + then: + properties: + clocks: + minItems: 3 + maxItems: 3 + clock-names: + minItems: 3 + maxItems: 3 + power-domains: + minItems: 1 + required: + - clock-names + - power-domains + - if: + not: + properties: + compatible: + contains: + enum: + - fsl,imx6sx-lcdif + - fsl,imx8mp-lcdif + then: properties: clocks: maxItems: 1
i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names. This SoC requires a power-domain for this peripheral to use. Add it as a required property. Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- Changes in v2: * Squash both patches into one * Split the conditionals from fsl,imx6sx-lcdif * Mark power-domains as required for fsl,imx8mp-lcdif * Ignored the A-b & R-b due to reorganization I'm not sure if this is the best way to add the constraints. I noticed that imx6sx also uses a power-domain, but imx6ul which is compatible to imx6sx does not, so they can't be merged. I also have noticed that dtbs_check doesn't raise a warning when power-domains is actually missing. .../bindings/display/fsl,lcdif.yaml | 31 ++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-)