diff mbox series

[BlueZ,v2,2/8] shared/bap: Fix initiating QoS and Enable procedures as server

Message ID 20221202005051.2401504-2-luiz.dentz@gmail.com
State New
Headers show
Series [BlueZ,v2,1/8] shared/bap: Fix not reading all instances of PAC Sinks/Sources | expand

Commit Message

Luiz Augusto von Dentz Dec. 2, 2022, 12:50 a.m. UTC 
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

According to Table 3.2: ASE state machine transition these procedures
can only be initated by clients.
---
 src/shared/bap.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)
diff mbox series

Patch

diff --git a/src/shared/bap.c b/src/shared/bap.c
index 7a24824a71fc..f4812a4b9f51 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -4166,14 +4166,12 @@  unsigned int bt_bap_stream_qos(struct bt_bap_stream *stream,
 	struct bt_ascs_qos qos;
 	struct bt_bap_req *req;
 
-	if (!bap_stream_valid(stream))
+	/* Table 3.2: ASE state machine transition
+	 * Initiating device - client Only
+	 */
+	if (!bap_stream_valid(stream) || !stream->client)
 		return 0;
 
-	if (!stream->client) {
-		stream_qos(stream, data, NULL);
-		return 0;
-	}
-
 	memset(&qos, 0, sizeof(qos));
 
 	/* TODO: Figure out how to pass these values around */
@@ -4259,14 +4257,12 @@  unsigned int bt_bap_stream_enable(struct bt_bap_stream *stream,
 {
 	int ret;
 
-	if (!bap_stream_valid(stream))
+	/* Table 3.2: ASE state machine transition
+	 * Initiating device - client Only
+	 */
+	if (!bap_stream_valid(stream) || !stream->client)
 		return 0;
 
-	if (!stream->client) {
-		stream_enable(stream, metadata, NULL);
-		return 0;
-	}
-
 	ret = bap_stream_metadata(stream, BT_ASCS_ENABLE, metadata, func,
 								user_data);
 	if (!ret || !enable_links)