diff mbox

[edk2,3/4] ArmPlatformPkg: PL061 - drop pointless initialize function

Message ID 1456503415-17029-4-git-send-email-leif.lindholm@linaro.org
State Accepted
Commit 41501f18fdc003f973460057e36fa097dca3e571
Headers show

Commit Message

Leif Lindholm Feb. 26, 2016, 4:16 p.m. UTC 
PL061Initialize() did not actually do anything other than call
PL061Identify() - so cut out the middle man.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

---
 ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 27 +------------------------
 1 file changed, 1 insertion(+), 26 deletions(-)

-- 
2.1.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox

Patch

diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
index c8125fd..45897ca 100644
--- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
+++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
@@ -57,31 +57,6 @@  PL061Identify (
   return EFI_SUCCESS;
 }
 
-EFI_STATUS
-PL061Initialize (
-  VOID
-  )
-{
-  EFI_STATUS  Status;
-
-  // Check if the PL061 GPIO module exists on board
-  Status = PL061Identify();
-  if (EFI_ERROR (Status)) {
-    Status = EFI_DEVICE_ERROR;
-    goto EXIT;
-  }
-
-  // Do other hardware initialisation things here as required
-
-  // Disable Interrupts
-  //if (MmioRead8 (PL061_GPIO_IE_REG) != 0) {
-  //   // Ensure interrupts are disabled
-  //}
-
-  EXIT:
-  return Status;
-}
-
 /**
 
 Routine Description:
@@ -298,7 +273,7 @@  PL061InstallProtocol (
   //
   ASSERT_PROTOCOL_ALREADY_INSTALLED (NULL, &gEmbeddedGpioProtocolGuid);
 
-  Status = PL061Initialize();
+  Status = PL061Identify();
   if (EFI_ERROR(Status)) {
     return EFI_DEVICE_ERROR;
   }