| Message ID | 20221202174746.1218017-1-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RFC,for,8.0] configure: repeat ourselves for the benefit of CI | expand |
On 2/12/22 18:47, Alex Bennée wrote: > Our CI system echos the lines it executes but not the expansions. For > the sake of a line of extra verbosity during the configure phase lets > echo the invocation of script to stdout as well as the log. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > configure | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/configure b/configure > index 26c7bc5154..849ac7aed9 100755 > --- a/configure > +++ b/configure > @@ -83,9 +83,10 @@ rm -f config.log > # Print a helpful header at the top of config.log > echo "# QEMU configure log $(date)" >> config.log > printf "# Configured with:" >> config.log > -printf " '%s'" "$0" "$@" >> config.log > -echo >> config.log > -echo "#" >> config.log > +# repeat the invocation to log and stdout for CI > +invoke=$(printf " '%s'" "$0" "$@") > +echo "configuring with: $invoke" test -n $GITLAB_CI && ... ? > +{ echo "$invoke"; echo; echo "#"; } >> config.log > > quote_sh() { > printf "%s" "$1" | sed "s,','\\\\'',g; s,.*,'&',"
diff --git a/configure b/configure index 26c7bc5154..849ac7aed9 100755 --- a/configure +++ b/configure @@ -83,9 +83,10 @@ rm -f config.log # Print a helpful header at the top of config.log echo "# QEMU configure log $(date)" >> config.log printf "# Configured with:" >> config.log -printf " '%s'" "$0" "$@" >> config.log -echo >> config.log -echo "#" >> config.log +# repeat the invocation to log and stdout for CI +invoke=$(printf " '%s'" "$0" "$@") +echo "configuring with: $invoke" +{ echo "$invoke"; echo; echo "#"; } >> config.log quote_sh() { printf "%s" "$1" | sed "s,','\\\\'',g; s,.*,'&',"
Our CI system echos the lines it executes but not the expansions. For the sake of a line of extra verbosity during the configure phase lets echo the invocation of script to stdout as well as the log. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- configure | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)