diff mbox series

[resend] mfd: pm8008: Fix return value check in pm8008_probe()

Message ID 20221125073626.1868229-1-yangyingliang@huawei.com
State Accepted
Commit 14f8c55d48e02157519fbcb3a5de557abd8a06e2
Headers show
Series [resend] mfd: pm8008: Fix return value check in pm8008_probe() | expand

Commit Message

Yang Yingliang Nov. 25, 2022, 7:36 a.m. UTC
In case of error, the function devm_regmap_init_i2c() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Acked-by: Guru Das Srinagesh <gurus@codeaurora.org>
---
The previous patch link:
https://lore.kernel.org/lkml/20210605022446.4119978-1-yangyingliang@huawei.com/
---
 drivers/mfd/qcom-pm8008.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Lee Jones Dec. 8, 2022, 2:39 p.m. UTC | #1
On Fri, 25 Nov 2022, Yang Yingliang wrote:

> In case of error, the function devm_regmap_init_i2c() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
> 
> Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Acked-by: Guru Das Srinagesh <gurus@codeaurora.org>
> ---
> The previous patch link:
> https://lore.kernel.org/lkml/20210605022446.4119978-1-yangyingliang@huawei.com/
> ---
>  drivers/mfd/qcom-pm8008.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
index 4b8ff947762f..9f3c4a01b4c1 100644
--- a/drivers/mfd/qcom-pm8008.c
+++ b/drivers/mfd/qcom-pm8008.c
@@ -215,8 +215,8 @@  static int pm8008_probe(struct i2c_client *client)
 
 	dev = &client->dev;
 	regmap = devm_regmap_init_i2c(client, &qcom_mfd_regmap_cfg);
-	if (!regmap)
-		return -ENODEV;
+	if (IS_ERR(regmap))
+		return PTR_ERR(regmap);
 
 	i2c_set_clientdata(client, regmap);