| Message ID | 20221128173744.833018-1-luca@z3ntu.xyz |
|---|---|
| State | Accepted |
| Commit | a933e7f05bd413bcfd5fb103ad86519526a49446 |
| Headers | show |
| Series | [RESEND,1/2] dt-bindings: nfc: nxp,nci: Document NQ310 compatible | expand |
On 28.11.2022 18:37, Luca Weiss wrote: > Configure the node for the NQ310 chip found on this device, which is > compatible with generic nxp-nci-i2c driver. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > RESEND to fix Cc > > arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > index 2920504461d3..fde93cbcd180 100644 > --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > @@ -63,6 +63,21 @@ touchscreen@48 { > }; > }; > > +&i2c_5 { > + status = "okay"; > + > + nfc@28 { > + compatible = "nxp,nq310", "nxp,nxp-nci-i2c"; Unless there was some binding change (that was not emailed to me with this email, I only got 2/2), only "nxp,nxp-nci-i2c" and "nxp,pn547", "nxp,nxp-nci-i2c" are allowed. The node looks good though. Konrad > + reg = <0x28>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; > + > + enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>; > + firmware-gpios = <&tlmm 62 GPIO_ACTIVE_HIGH>; > + }; > +}; > + > &pm8953_resin { > status = "okay"; > linux,code = <KEY_VOLUMEDOWN>;
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Mon, 28 Nov 2022 18:37:43 +0100 you wrote: > The NQ310 is another NFC chip from NXP, document the compatible in the > bindings. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > RESEND to fix Cc > > [...] Here is the summary with links: - [RESEND,1/2] dt-bindings: nfc: nxp,nci: Document NQ310 compatible https://git.kernel.org/netdev/net-next/c/a933e7f05bd4 You are awesome, thank you!
On Mon, 28 Nov 2022 18:37:43 +0100, Luca Weiss wrote: > The NQ310 is another NFC chip from NXP, document the compatible in the > bindings. > > Applied, thanks! [2/2] arm64: dts: qcom: sdm632-fairphone-fp3: Add NFC commit: 29dcf3c1a8159acdf56905c377a214381eda5a24 Best regards,
diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml index b2558421268a..6924aff0b2c5 100644 --- a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml +++ b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml @@ -14,7 +14,9 @@ properties: oneOf: - const: nxp,nxp-nci-i2c - items: - - const: nxp,pn547 + - enum: + - nxp,nq310 + - nxp,pn547 - const: nxp,nxp-nci-i2c enable-gpios:
The NQ310 is another NFC chip from NXP, document the compatible in the bindings. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- RESEND to fix Cc Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)