diff mbox series

crypto: x86/curve25519 - disable gcov

Message ID 20221122225450.789234-1-joefradley@google.com
State Accepted
Commit c390c452ebeb44cb979b7374d3acc3859415e86c
Headers show
Series crypto: x86/curve25519 - disable gcov | expand

Commit Message

Joe Fradley Nov. 22, 2022, 10:54 p.m. UTC
curve25519-x86_64.c fails to build when CONFIG_GCOV_KERNEL is enabled.
The error is "inline assembly requires more registers than available"
thrown from the `fsqr()` function. Therefore, excluding this file from
GCOV profiling until this issue is resolved. Thereby allowing
CONFIG_GCOV_PROFILE_ALL to be enabled for x86.

Signed-off-by: Joe Fradley <joefradley@google.com>
---
 arch/x86/crypto/Makefile | 3 +++
 1 file changed, 3 insertions(+)

Comments

Herbert Xu Dec. 2, 2022, 10:20 a.m. UTC | #1
On Tue, Nov 22, 2022 at 02:54:49PM -0800, Joe Fradley wrote:
> curve25519-x86_64.c fails to build when CONFIG_GCOV_KERNEL is enabled.
> The error is "inline assembly requires more registers than available"
> thrown from the `fsqr()` function. Therefore, excluding this file from
> GCOV profiling until this issue is resolved. Thereby allowing
> CONFIG_GCOV_PROFILE_ALL to be enabled for x86.
> 
> Signed-off-by: Joe Fradley <joefradley@google.com>
> ---
>  arch/x86/crypto/Makefile | 3 +++
>  1 file changed, 3 insertions(+)

Patch applied.  Thanks.
diff mbox series

Patch

diff --git a/arch/x86/crypto/Makefile b/arch/x86/crypto/Makefile
index 3b1d701a4f6c..3e7a329235bd 100644
--- a/arch/x86/crypto/Makefile
+++ b/arch/x86/crypto/Makefile
@@ -107,3 +107,6 @@  quiet_cmd_perlasm = PERLASM $@
       cmd_perlasm = $(PERL) $< > $@
 $(obj)/%.S: $(src)/%.pl FORCE
 	$(call if_changed,perlasm)
+
+# Disable GCOV in odd or sensitive code
+GCOV_PROFILE_curve25519-x86_64.o := n