| Message ID | 20221122231235.3299737-4-dmitry.baryshkov@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | drm/msm: add support for SM8450 | expand |
On 23/11/2022 00:12, Dmitry Baryshkov wrote: > Mark clock-names property as required to be used on all MDSS devices. This we see from the diff. Please tell why you are doing it. In some other recent bindings we dropped clock-names from required, so this is confusing. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Documentation/devicetree/bindings/display/msm/mdss-common.yaml | 1 + Best regards, Krzysztof
On 23/11/2022 12:19, Krzysztof Kozlowski wrote: > On 23/11/2022 00:12, Dmitry Baryshkov wrote: >> Mark clock-names property as required to be used on all MDSS devices. > > This we see from the diff. Please tell why you are doing it. In some > other recent bindings we dropped clock-names from required, so this is > confusing. Thanks for the question. It looks like you are correct and we do not need clock-names for the new mdss devices (only for the DPU devices and for the old qcom,mdss binding, but it's another story). So, I'll drop this patch from the series. And for the next cycle I will check whether we can drop the clock-names from existing dtsi files (and from schema too).
diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml index 59f17ac898aa..e2980aebf178 100644 --- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml +++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml @@ -74,6 +74,7 @@ required: - reg-names - power-domains - clocks + - clock-names - interrupts - interrupt-controller - iommus
Mark clock-names property as required to be used on all MDSS devices. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Documentation/devicetree/bindings/display/msm/mdss-common.yaml | 1 + 1 file changed, 1 insertion(+)