| Message ID | 20221116113128.2655441-1-abel.vesa@linaro.org |
|---|---|
| State | Accepted |
| Commit | 1f0067c6e9be3ef30fca18c409c61565bffc0407 |
| Headers | show |
| Series | dt-bindings: soc: qcom: aoss: Add compatible for SM8550 | expand |
On 22-11-16 12:43:26, Krzysztof Kozlowski wrote: > On 16/11/2022 12:31, Abel Vesa wrote: > > Document the compatible for SM8550. > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > Why this is not part of other SoC patches? I just received many single > patches for this SM8550 topic. All these should be set of few series, > not 10 or more... Fair point. Will do that next iteration then. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks, Abel > > Best regards, > Krzysztof >
On Wed, Nov 16, 2022 at 12:43:26PM +0100, Krzysztof Kozlowski wrote: > On 16/11/2022 12:31, Abel Vesa wrote: > > Document the compatible for SM8550. > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > Why this is not part of other SoC patches? I just received many single > patches for this SM8550 topic. All these should be set of few series, > not 10 or more... > Because these patches are independent of each other and done in this way means the maintainer can merge each piece on its own. I much prefer this over having these series with 20+ patches being sent over and over because one of the patches is getting feedback. Regards, Bjorn > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof >
On 05/12/2022 22:16, Bjorn Andersson wrote: > On Wed, Nov 16, 2022 at 12:43:26PM +0100, Krzysztof Kozlowski wrote: >> On 16/11/2022 12:31, Abel Vesa wrote: >>> Document the compatible for SM8550. >>> >>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> >> >> Why this is not part of other SoC patches? I just received many single >> patches for this SM8550 topic. All these should be set of few series, >> not 10 or more... >> > > Because these patches are independent of each other and done in this way > means the maintainer can merge each piece on its own. I much prefer this > over having these series with 20+ patches being sent over and over > because one of the patches is getting feedback. But this one is patch for you, so should go with other patches targeting Qualcomm subarch. Before submission, we discussed extensively the proposed split per patches and it was agreed on. Yet this one here was a surprise. Best regards, Krzysztof
On Wed, 16 Nov 2022 13:31:28 +0200, Abel Vesa wrote: > Document the compatible for SM8550. > > Applied, thanks! [1/1] dt-bindings: soc: qcom: aoss: Add compatible for SM8550 commit: 1f0067c6e9be3ef30fca18c409c61565bffc0407 Best regards,
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml index da232f8d20d2..98d087cf4fc0 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml @@ -35,6 +35,7 @@ properties: - qcom,sm8250-aoss-qmp - qcom,sm8350-aoss-qmp - qcom,sm8450-aoss-qmp + - qcom,sm8550-aoss-qmp - const: qcom,aoss-qmp reg:
Document the compatible for SM8550. Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml | 1 + 1 file changed, 1 insertion(+)