| Message ID | 20221108061113.35964-1-yuehaibing@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | phy: usb: sunplus: Fix memleak in update_disc_vol() | expand |
diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c index e827b79f6d49..450cf8e6d7fb 100644 --- a/drivers/phy/sunplus/phy-sunplus-usb2.c +++ b/drivers/phy/sunplus/phy-sunplus-usb2.c @@ -96,6 +96,7 @@ static int update_disc_vol(struct sp_usbphy *usbphy) set = *(otp_v + 1); set = (set << (sizeof(char) * 8)) | *otp_v; set = (set >> usbphy->disc_vol_addr_off) & J_DISC; + kfree(otp_v); } if (IS_ERR(otp_v) || set == 0)
'otp_v' is allocated in nvmem_cell_read(), it should be freed before return. Fixes: 99d9ccd97385 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/phy/sunplus/phy-sunplus-usb2.c | 1 + 1 file changed, 1 insertion(+)