| Message ID | 20221109152356.39868-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 802e19a066c40017321a0717817785d861aedc53 |
| Headers | show |
| Series | [v1,1/1] pinctrl: Put space between type and data in compound literal | expand |
On Wed, Nov 9, 2022 at 4:23 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > It's slightly better to read when compound literal data and type > are separated by a space. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Patch applied. Yours, Linus Walleij
diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h index 487117ccb1bc..f6ff2590657d 100644 --- a/include/linux/pinctrl/pinctrl.h +++ b/include/linux/pinctrl/pinctrl.h @@ -40,7 +40,7 @@ struct pingroup { /* Convenience macro to define a single named or anonymous pingroup */ #define PINCTRL_PINGROUP(_name, _pins, _npins) \ -(struct pingroup){ \ +(struct pingroup) { \ .name = _name, \ .pins = _pins, \ .npins = _npins, \
It's slightly better to read when compound literal data and type are separated by a space. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- It also standard practice in the kernel: $ git grep -l '(struct [^()]\+) {' | wc -l 1384 $ git grep -l '(struct [^()]\+){' | wc -l 306 include/linux/pinctrl/pinctrl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)