| Message ID | 20221109100928.109478-2-vivek.2311@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/6] dt-bindings: Document the SYSREG specific compatibles found on FSD SoC | expand |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 09 November 2022 16:39 > To: Vivek Yadav <vivek.2311@samsung.com>; rcsekar@samsung.com; > krzysztof.kozlowski+dt@linaro.org; wg@grandegger.com; > mkl@pengutronix.de; davem@davemloft.net; edumazet@google.com; > kuba@kernel.org; pabeni@redhat.com; pankaj.dubey@samsung.com; > ravi.patel@samsung.com; alim.akhtar@samsung.com; linux-fsd@tesla.com; > robh+dt@kernel.org > Cc: linux-can@vger.kernel.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org; devicetree@vger.kernel.org; > aswani.reddy@samsung.com; sriranjani.p@samsung.com > Subject: Re: [PATCH v2 1/6] dt-bindings: Document the SYSREG specific > compatibles found on FSD SoC > > On 09/11/2022 11:09, Vivek Yadav wrote: > > From: Sriranjani P <sriranjani.p@samsung.com> > > > > Use subject prefixes matching the subsystem (git log --oneline -- ...). > Okay, I will add the correct prefixes. > > Describe the compatible properties for SYSREG controllers found on FSD > > SoC. > > This is ARM SoC patch, split it from the patchset. > I understand this patch is not to be subset of CAN patches, I will send these patches separately. These patches will be used by EQos patches. As per reference, I am adding the Address link. https://lore.kernel.org/all/20221104120517.77980-1-sriranjani.p@samsung.com/ > > > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > > Signed-off-by: Pankaj Kumar Dubey <pankaj.dubey@samsung.com> > > Signed-off-by: Ravi Patel <ravi.patel@samsung.com> > > Signed-off-by: Vivek Yadav <vivek.2311@samsung.com> > > Cc: devicetree@vger.kernel.org > > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > > Cc: Rob Herring <robh+dt@kernel.org> > > Drop the Cc list from commit log. It's not helpful. > Okay, I will remove. > > Signed-off-by: Sriranjani P <sriranjani.p@samsung.com> > > --- > > .../devicetree/bindings/arm/tesla-sysreg.yaml | 50 > +++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 51 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/arm/tesla-sysreg.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml > > b/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml > > new file mode 100644 > > index 000000000000..bbcc6dd75918 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml > > arm is only for top level stuff. This goes to soc under tesla or samsung > directory. > Okay, this is specific to Samsung fsd SoC, I will be moving this file to arm/samsung in next patch series. Hope that is fine. > > @@ -0,0 +1,50 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 > > +--- > > +$id: > > +https://protect2.fireeye.com/v1/url?k=1ad2834a-7b59967c-1ad30805- > 000b > > +abff9b5d-1f65584e412e916c&q=1&e=a870a282-632a-4896-ae53- > 3ecb50f02be5& > > +u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Farm%2Ftesla- > sysreg.yaml%23 > > +$schema: > > +https://protect2.fireeye.com/v1/url?k=13876e33-720c7b05-1386e57c- > 000b > > +abff9b5d-edae3ff711999305&q=1&e=a870a282-632a-4896-ae53- > 3ecb50f02be5& > > +u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > > + > > +title: Tesla Full Self-Driving platform's system registers > > + > > +maintainers: > > + - Alim Akhtar <alim.akhtar@samsung.com> > > + > > +description: | > > + This is a system control registers block, providing multiple low > > +level > > + platform functions like board detection and identification, > > +software > > + interrupt generation. > > + > > +properties: > > + compatible: > > + oneOf: > > No need for oneOf. > Removing this results into dt_binding_check error, so this is required. > > + - items: > > + - enum: > > + - tesla,sysreg_fsys0 > > + - tesla,sysreg_peric > > From where did you get underscores in compatibles? > I have seen in MCAN Driver <drivers/net/can/m_can/m_can_platform.c> and also too many other yaml files. Do you have any ref standard guideline of compatible which says underscore is not allowed. > > + - const: syscon > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + sysreg_fsys0: system-controller@15030000 { > > + compatible = "tesla,sysreg_fsys0", "syscon"; > > Use 4 spaces for example indentation. > Okay I will make it 4 spaces indentation. > > + reg = <0x0 0x15030000 0x0 0x1000>; > > + }; > > + > > + sysreg_peric: system-controller@14030000 { > > + compatible = "tesla,sysreg_peric", "syscon"; > > + reg = <0x0 0x14030000 0x0 0x1000>; > > + }; > > One example is enough, they are the same. kay I will remove 1 example. > > + }; > > diff --git a/MAINTAINERS b/MAINTAINERS index > > a198da986146..56995e7d63ad 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -2943,6 +2943,7 @@ M: linux-fsd@tesla.com > > L: linux-arm-kernel@lists.infradead.org (moderated for non- > subscribers) > > L: linux-samsung-soc@vger.kernel.org > > S: Maintained > > +F: Documentation/devicetree/bindings/arm/tesla-sysreg.yaml > > F: arch/arm64/boot/dts/tesla* > > > > ARM/TETON BGA MACHINE SUPPORT > > Best regards, > Krzysztof Thanks for reviewing the patches.
diff --git a/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml b/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml new file mode 100644 index 000000000000..bbcc6dd75918 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/tesla-sysreg.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Tesla Full Self-Driving platform's system registers + +maintainers: + - Alim Akhtar <alim.akhtar@samsung.com> + +description: | + This is a system control registers block, providing multiple low level + platform functions like board detection and identification, software + interrupt generation. + +properties: + compatible: + oneOf: + - items: + - enum: + - tesla,sysreg_fsys0 + - tesla,sysreg_peric + - const: syscon + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + soc { + #address-cells = <2>; + #size-cells = <2>; + + sysreg_fsys0: system-controller@15030000 { + compatible = "tesla,sysreg_fsys0", "syscon"; + reg = <0x0 0x15030000 0x0 0x1000>; + }; + + sysreg_peric: system-controller@14030000 { + compatible = "tesla,sysreg_peric", "syscon"; + reg = <0x0 0x14030000 0x0 0x1000>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index a198da986146..56995e7d63ad 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2943,6 +2943,7 @@ M: linux-fsd@tesla.com L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) L: linux-samsung-soc@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/arm/tesla-sysreg.yaml F: arch/arm64/boot/dts/tesla* ARM/TETON BGA MACHINE SUPPORT