diff mbox series

video: fbdev: pxafb: Remove unnecessary print function dev_err()

Message ID 278d64e0.bd.1844d4c7a95.Coremail.wangkailong@jari.cn
State New
Headers show
Series video: fbdev: pxafb: Remove unnecessary print function dev_err() | expand

Commit Message

KaiLong Wang Nov. 6, 2022, 2:16 p.m. UTC
Eliminate the follow coccicheck warning:

./drivers/video/fbdev/pxafb.c:2330:2-9: line 2330 is redundant because
platform_get_irq() already prints an error

Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
---
 drivers/video/fbdev/pxafb.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Helge Deller Nov. 7, 2022, 8:52 a.m. UTC | #1
On 11/6/22 15:16, wangkailong@jari.cn wrote:
> Eliminate the follow coccicheck warning:
>
> ./drivers/video/fbdev/pxafb.c:2330:2-9: line 2330 is redundant because
> platform_get_irq() already prints an error
>
> Signed-off-by: KaiLong Wang <wangkailong@jari.cn>

applied.
Thanks!
Helge

> ---
>   drivers/video/fbdev/pxafb.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
> index 696ac5431180..c46ed78298ae 100644
> --- a/drivers/video/fbdev/pxafb.c
> +++ b/drivers/video/fbdev/pxafb.c
> @@ -2327,7 +2327,6 @@ static int pxafb_probe(struct platform_device *dev)
>
>   	irq = platform_get_irq(dev, 0);
>   	if (irq < 0) {
> -		dev_err(&dev->dev, "no IRQ defined\n");
>   		ret = -ENODEV;
>   		goto failed_free_mem;
>   	}
diff mbox series

Patch

diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
index 696ac5431180..c46ed78298ae 100644
--- a/drivers/video/fbdev/pxafb.c
+++ b/drivers/video/fbdev/pxafb.c
@@ -2327,7 +2327,6 @@  static int pxafb_probe(struct platform_device *dev)
 
 	irq = platform_get_irq(dev, 0);
 	if (irq < 0) {
-		dev_err(&dev->dev, "no IRQ defined\n");
 		ret = -ENODEV;
 		goto failed_free_mem;
 	}