| Message ID | 20221030094258.486428-2-iskren.chernev@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v5,1/8] dt-bindings: ufs: qcom: Add sm6115 binding | expand |
On 10/30/22 3:12 PM, Iskren Chernev wrote: > Add SM6115 UFS to DT schema. > > Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/ufs/qcom,ufs.yaml | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > index f2d6298d926c..b517d76215e3 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > @@ -28,6 +28,7 @@ properties: > - qcom,msm8998-ufshc > - qcom,sc8280xp-ufshc > - qcom,sdm845-ufshc > + - qcom,sm6115-ufshc > - qcom,sm6350-ufshc > - qcom,sm8150-ufshc > - qcom,sm8250-ufshc > @@ -178,6 +179,31 @@ allOf: > minItems: 1 > maxItems: 1 > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sm6115-ufshc > + then: > + properties: > + clocks: > + minItems: 8 > + maxItems: 8 > + clock-names: > + items: > + - const: core_clk > + - const: bus_aggr_clk > + - const: iface_clk > + - const: core_clk_unipro > + - const: ref_clk > + - const: tx_lane0_sync_clk > + - const: rx_lane0_sync_clk > + - const: ice_core_clk > + reg: > + minItems: 2 > + maxItems: 2 > + > # TODO: define clock bindings for qcom,msm8994-ufshc > > unevaluatedProperties: false Seems this hasn't made way to linux-next yet. Hence we get the following error with $ make dtbs_check: arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dtb: ufs@4804000: compatible:0: 'qcom,sm6115-ufshc' is not one of ['qcom,msm8994-ufshc', 'qcom,msm8996-ufshc', 'qcom,msm8998-ufshc', 'qcom,sc8280xp-ufshc', 'qcom,sdm845-ufshc', 'qcom,sm6350-ufshc', 'qcom,sm8150-ufshc', 'qcom,sm8250-ufshc', 'qcom,sm8350-ufshc', 'qcom,sm8450-ufshc'] From schema: Documentation/devicetree/bindings/ufs/qcom,ufs.yaml arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dtb: ufs@4804000: Unevaluated properties are not allowed ('compatible' was unexpected) From schema: Documentation/devicetree/bindings/ufs/qcom,ufs.yaml If, it helps to get the review / merge happen: Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> @Rob, @Krzysztof: Please help merge this. Thanks.
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index f2d6298d926c..b517d76215e3 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -28,6 +28,7 @@ properties: - qcom,msm8998-ufshc - qcom,sc8280xp-ufshc - qcom,sdm845-ufshc + - qcom,sm6115-ufshc - qcom,sm6350-ufshc - qcom,sm8150-ufshc - qcom,sm8250-ufshc @@ -178,6 +179,31 @@ allOf: minItems: 1 maxItems: 1 + - if: + properties: + compatible: + contains: + enum: + - qcom,sm6115-ufshc + then: + properties: + clocks: + minItems: 8 + maxItems: 8 + clock-names: + items: + - const: core_clk + - const: bus_aggr_clk + - const: iface_clk + - const: core_clk_unipro + - const: ref_clk + - const: tx_lane0_sync_clk + - const: rx_lane0_sync_clk + - const: ice_core_clk + reg: + minItems: 2 + maxItems: 2 + # TODO: define clock bindings for qcom,msm8994-ufshc unevaluatedProperties: false