| Message ID | 20221031220205.91975-1-brian.gix@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RFC] Bluetooth: Convert MSFT filter HCI cmd to hci_sync | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=690652 ---Test result--- Test Summary: CheckPatch PASS 0.77 seconds GitLint PASS 0.38 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 41.72 seconds BuildKernel32 PASS 38.33 seconds TestRunnerSetup PASS 507.69 seconds TestRunner_l2cap-tester PASS 18.20 seconds TestRunner_iso-tester PASS 18.34 seconds TestRunner_bnep-tester PASS 6.43 seconds TestRunner_mgmt-tester PASS 121.16 seconds TestRunner_rfcomm-tester PASS 10.91 seconds TestRunner_sco-tester PASS 10.17 seconds TestRunner_ioctl-tester PASS 11.67 seconds TestRunner_mesh-tester PASS 8.12 seconds TestRunner_smp-tester PASS 10.05 seconds TestRunner_userchan-tester PASS 6.88 seconds IncrementalBuild PASS 38.73 seconds --- Regards, Linux Bluetooth
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=690652 ---Test result--- Test Summary: CheckPatch PASS 0.59 seconds GitLint PASS 0.28 seconds SubjectPrefix PASS 0.09 seconds BuildKernel PASS 34.10 seconds BuildKernel32 PASS 30.42 seconds TestRunnerSetup PASS 420.82 seconds TestRunner_l2cap-tester PASS 15.66 seconds TestRunner_iso-tester PASS 14.89 seconds TestRunner_bnep-tester PASS 5.26 seconds TestRunner_mgmt-tester PASS 106.33 seconds TestRunner_rfcomm-tester PASS 9.09 seconds TestRunner_sco-tester PASS 8.65 seconds TestRunner_ioctl-tester PASS 9.89 seconds TestRunner_mesh-tester PASS 6.66 seconds TestRunner_smp-tester PASS 8.39 seconds TestRunner_userchan-tester PASS 5.53 seconds IncrementalBuild PASS 30.62 seconds --- Regards, Linux Bluetooth
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=690652 ---Test result--- Test Summary: CheckPatch PASS 0.66 seconds GitLint PASS 0.33 seconds SubjectPrefix PASS 0.11 seconds BuildKernel PASS 34.17 seconds BuildKernel32 PASS 29.89 seconds TestRunnerSetup PASS 420.10 seconds TestRunner_l2cap-tester PASS 16.04 seconds TestRunner_iso-tester PASS 15.41 seconds TestRunner_bnep-tester PASS 5.39 seconds TestRunner_mgmt-tester PASS 104.21 seconds TestRunner_rfcomm-tester PASS 9.14 seconds TestRunner_sco-tester PASS 8.54 seconds TestRunner_ioctl-tester PASS 9.80 seconds TestRunner_mesh-tester PASS 6.65 seconds TestRunner_smp-tester PASS 8.38 seconds TestRunner_userchan-tester PASS 5.65 seconds IncrementalBuild PASS 30.65 seconds --- Regards, Linux Bluetooth
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=690652 ---Test result--- Test Summary: CheckPatch PASS 0.67 seconds GitLint PASS 0.33 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 34.29 seconds BuildKernel32 PASS 30.36 seconds TestRunnerSetup PASS 420.04 seconds TestRunner_l2cap-tester PASS 15.69 seconds TestRunner_iso-tester PASS 15.03 seconds TestRunner_bnep-tester PASS 5.35 seconds TestRunner_mgmt-tester PASS 103.66 seconds TestRunner_rfcomm-tester PASS 9.17 seconds TestRunner_sco-tester PASS 8.64 seconds TestRunner_ioctl-tester PASS 9.88 seconds TestRunner_mesh-tester PASS 6.70 seconds TestRunner_smp-tester PASS 8.43 seconds TestRunner_userchan-tester PASS 5.64 seconds IncrementalBuild PASS 31.45 seconds --- Regards, Linux Bluetooth
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=690652 ---Test result--- Test Summary: CheckPatch PASS 0.75 seconds GitLint PASS 0.38 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 38.69 seconds BuildKernel32 PASS 34.79 seconds TestRunnerSetup PASS 489.22 seconds TestRunner_l2cap-tester PASS 17.50 seconds TestRunner_iso-tester PASS 17.58 seconds TestRunner_bnep-tester PASS 6.30 seconds TestRunner_mgmt-tester PASS 118.97 seconds TestRunner_rfcomm-tester PASS 10.72 seconds TestRunner_sco-tester PASS 10.03 seconds TestRunner_ioctl-tester PASS 11.72 seconds TestRunner_mesh-tester PASS 8.04 seconds TestRunner_smp-tester PASS 9.84 seconds TestRunner_userchan-tester PASS 6.84 seconds IncrementalBuild PASS 37.34 seconds --- Regards, Linux Bluetooth
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=690652 ---Test result--- Test Summary: CheckPatch PASS 0.67 seconds GitLint PASS 0.33 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 33.73 seconds BuildKernel32 PASS 29.94 seconds TestRunnerSetup PASS 418.97 seconds TestRunner_l2cap-tester PASS 16.05 seconds TestRunner_iso-tester PASS 15.06 seconds TestRunner_bnep-tester PASS 5.36 seconds TestRunner_mgmt-tester PASS 104.08 seconds TestRunner_rfcomm-tester PASS 9.08 seconds TestRunner_sco-tester PASS 8.57 seconds TestRunner_ioctl-tester PASS 9.68 seconds TestRunner_mesh-tester PASS 6.72 seconds TestRunner_smp-tester PASS 8.43 seconds TestRunner_userchan-tester PASS 5.54 seconds IncrementalBuild PASS 30.81 seconds --- Regards, Linux Bluetooth
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=690652 ---Test result--- Test Summary: CheckPatch PASS 0.70 seconds GitLint PASS 0.35 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 33.82 seconds BuildKernel32 PASS 30.51 seconds TestRunnerSetup PASS 425.75 seconds TestRunner_l2cap-tester PASS 16.35 seconds TestRunner_iso-tester PASS 15.92 seconds TestRunner_bnep-tester PASS 5.60 seconds TestRunner_mgmt-tester PASS 105.95 seconds TestRunner_rfcomm-tester PASS 9.50 seconds TestRunner_sco-tester PASS 8.96 seconds TestRunner_ioctl-tester PASS 10.28 seconds TestRunner_mesh-tester PASS 6.99 seconds TestRunner_smp-tester PASS 8.75 seconds TestRunner_userchan-tester PASS 5.89 seconds IncrementalBuild PASS 31.59 seconds --- Regards, Linux Bluetooth
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=690652 ---Test result--- Test Summary: CheckPatch PASS 0.69 seconds GitLint PASS 0.34 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 33.65 seconds BuildKernel32 PASS 30.66 seconds TestRunnerSetup PASS 425.34 seconds TestRunner_l2cap-tester PASS 16.09 seconds TestRunner_iso-tester PASS 15.58 seconds TestRunner_bnep-tester PASS 5.55 seconds TestRunner_mgmt-tester PASS 106.91 seconds TestRunner_rfcomm-tester PASS 9.47 seconds TestRunner_sco-tester PASS 8.97 seconds TestRunner_ioctl-tester PASS 10.18 seconds TestRunner_mesh-tester PASS 7.08 seconds TestRunner_smp-tester PASS 8.77 seconds TestRunner_userchan-tester PASS 5.83 seconds IncrementalBuild PASS 31.51 seconds --- Regards, Linux Bluetooth
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=690652 ---Test result--- Test Summary: CheckPatch PASS 0.60 seconds GitLint PASS 0.29 seconds SubjectPrefix PASS 0.10 seconds BuildKernel PASS 33.72 seconds BuildKernel32 PASS 30.16 seconds TestRunnerSetup PASS 420.94 seconds TestRunner_l2cap-tester PASS 15.68 seconds TestRunner_iso-tester PASS 15.07 seconds TestRunner_bnep-tester PASS 5.26 seconds TestRunner_mgmt-tester PASS 103.94 seconds TestRunner_rfcomm-tester PASS 9.08 seconds TestRunner_sco-tester PASS 8.59 seconds TestRunner_ioctl-tester PASS 9.86 seconds TestRunner_mesh-tester PASS 6.69 seconds TestRunner_smp-tester PASS 8.41 seconds TestRunner_userchan-tester PASS 5.52 seconds IncrementalBuild PASS 31.24 seconds --- Regards, Linux Bluetooth
diff --git a/net/bluetooth/msft.c b/net/bluetooth/msft.c index bee6a4c656be..bf5cee48916c 100644 --- a/net/bluetooth/msft.c +++ b/net/bluetooth/msft.c @@ -743,17 +743,12 @@ __u64 msft_get_features(struct hci_dev *hdev) } static void msft_le_set_advertisement_filter_enable_cb(struct hci_dev *hdev, - u8 status, u16 opcode, - struct sk_buff *skb) + void *user_data, + u8 status) { - struct msft_cp_le_set_advertisement_filter_enable *cp; - struct msft_rp_le_set_advertisement_filter_enable *rp; + struct msft_cp_le_set_advertisement_filter_enable *cp = user_data; struct msft_data *msft = hdev->msft_data; - rp = (struct msft_rp_le_set_advertisement_filter_enable *)skb->data; - if (skb->len < sizeof(*rp)) - return; - /* Error 0x0C would be returned if the filter enabled status is * already set to whatever we were trying to set. * Although the default state should be disabled, some controller set @@ -766,7 +761,6 @@ static void msft_le_set_advertisement_filter_enable_cb(struct hci_dev *hdev, hci_dev_lock(hdev); - cp = hci_sent_cmd_data(hdev, hdev->msft_opcode); msft->filter_enabled = cp->enable; if (status == 0x0C) @@ -804,31 +798,23 @@ int msft_remove_monitor(struct hci_dev *hdev, struct adv_monitor *monitor) return msft_remove_monitor_sync(hdev, monitor); } -void msft_req_add_set_filter_enable(struct hci_request *req, bool enable) -{ - struct hci_dev *hdev = req->hdev; - struct msft_cp_le_set_advertisement_filter_enable cp; - - cp.sub_opcode = MSFT_OP_LE_SET_ADVERTISEMENT_FILTER_ENABLE; - cp.enable = enable; - - hci_req_add(req, hdev->msft_opcode, sizeof(cp), &cp); -} - int msft_set_filter_enable(struct hci_dev *hdev, bool enable) { - struct hci_request req; + struct msft_cp_le_set_advertisement_filter_enable cp; struct msft_data *msft = hdev->msft_data; int err; if (!msft) return -EOPNOTSUPP; - hci_req_init(&req, hdev); - msft_req_add_set_filter_enable(&req, enable); - err = hci_req_run_skb(&req, msft_le_set_advertisement_filter_enable_cb); + cp.sub_opcode = MSFT_OP_LE_SET_ADVERTISEMENT_FILTER_ENABLE; + cp.enable = enable; + err = __hci_cmd_sync_status(hdev, hdev->msft_opcode, sizeof(cp), &cp, + HCI_CMD_TIMEOUT); + + msft_le_set_advertisement_filter_enable_cb(hdev, &cp, err); - return err; + return 0; } bool msft_curve_validity(struct hci_dev *hdev)
The msft_set_filter_enable() command was using the deprecated hci_request mechanism rather than hci_sync. This caused the warning error: hci0: HCI_REQ-0xfcf0 Signed-off-by: Brian Gix <brian.gix@intel.com> --- net/bluetooth/msft.c | 36 +++++++++++------------------------- 1 file changed, 11 insertions(+), 25 deletions(-)