diff mbox series

dt-bindings: mfd: Expect specific type for monitored-battery

Message ID 20221028231309.565451-1-krzysztof.kozlowski@linaro.org
State New
Headers show
Series dt-bindings: mfd: Expect specific type for monitored-battery | expand

Commit Message

Krzysztof Kozlowski Oct. 28, 2022, 11:13 p.m. UTC
Core schema does not define type of monitored-battery, so the schemas
are expected to reference proper type.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/mfd/ene-kb930.yaml      | 4 +++-
 Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Lee Jones Oct. 31, 2022, 8:49 a.m. UTC | #1
On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote:

> Core schema does not define type of monitored-battery, so the schemas
> are expected to reference proper type.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/mfd/ene-kb930.yaml      | 4 +++-
>  Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 +
>  2 files changed, 4 insertions(+), 1 deletion(-)

Applied, thanks.
Rob Herring (Arm) Oct. 31, 2022, 7:26 p.m. UTC | #2
On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote:
> On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote:
> 
> > Core schema does not define type of monitored-battery, so the schemas
> > are expected to reference proper type.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/mfd/ene-kb930.yaml      | 4 +++-
> >  Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 +
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> Applied, thanks.

NAK. Please drop or revert.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/ene-kb930.yaml b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml
index 06ed9ec8f4bb..b4c6f9529ce1 100644
--- a/Documentation/devicetree/bindings/mfd/ene-kb930.yaml
+++ b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml
@@ -22,7 +22,9 @@  properties:
   reg:
     maxItems: 1
 
-  monitored-battery: true
+  monitored-battery:
+    $ref: /schemas/types.yaml#/definitions/phandle
+
   power-supplies: true
   system-power-controller: true
 
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
index 935e17099213..d136a05c7758 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
@@ -126,6 +126,7 @@  properties:
     type: object
     properties:
       monitored-battery:
+        $ref: /schemas/types.yaml#/definitions/phandle
         description: |
           A phandle to a monitored battery node that contains a valid
           value for: