| Message ID | 1455289804-1821-2-git-send-email-christophe.milard@linaro.org |
|---|---|
| State | Accepted |
| Commit | dd1ed7201be310a7e21c4855af9f3df2b9e68314 |
| Headers | show |
On 12 February 2016 at 15:16, Tilli, Juha-Matti (Nokia - FI/Espoo) < juha-matti.tilli@nokia.com> wrote: > Hi, > > Is there a tabulator in the first line of the commit message (i.e. in the > email subject)? If so, I would remove it and replace with a space. Applies > to many other patches in this series, as well. > Sorry: I cannot see any tab. at least where I am looking for... What problem are you seeing exactly? Christophe. > > -----Original Message----- > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of EXT > Christophe Milard > Sent: Friday, February 12, 2016 5:10 PM > To: anders.roxell@linaro.org; mike.holmes@linaro.org; > bill.fischofer@linaro.org; petri.savolainen@linaro.org > Cc: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCH 1/5] drv: creation of the driver > interface (drv) > > The Driver Programming Interface (drv) is defined in include/odp_drv.h and > include/odp/drv/spec directory. > > Signed-off-by: Christophe Milard <christophe.milard@linaro.org> > --- > include/odp/drv/spec/README | 4 ++++ > include/odp_drv.h | 24 ++++++++++++++++++++++++ > 2 files changed, 28 insertions(+) > create mode 100644 include/odp/drv/spec/README > create mode 100644 include/odp_drv.h > > diff --git a/include/odp/drv/spec/README b/include/odp/drv/spec/README > new file mode 100644 > index 0000000..cd017bf > --- /dev/null > +++ b/include/odp/drv/spec/README > @@ -0,0 +1,4 @@ > +This directory should contain files (including doxygen documentation) > defining > +the ODP Nic driver interface. > +The NIC driver interface is the south interface of ODP, which is used by > +PCI nic drivers. > diff --git a/include/odp_drv.h b/include/odp_drv.h > new file mode 100644 > index 0000000..b78fa9d > --- /dev/null > +++ b/include/odp_drv.h > @@ -0,0 +1,24 @@ > +/* Copyright (c) 2016, Linaro Limited > + * All rights reserved > + * > + * SPDX-License-Identifier: BSD-3-Clause > + */ > + > +/** > + * @file > + * > + * The OpenDataPlane nic driver programming interface > + * > + */ > + > +#ifndef ODP_DRV_H_ > +#define ODP_DRV_H_ > + > +#ifdef __cplusplus > +extern C { > +#endif > + > +#ifdef __cplusplus > +} > +#endif > +#endif > -- > 2.1.4 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
I cannot see any strange character in this. If anyone see the same, or can understand this problem, please let me know. Christophe. On 12 February 2016 at 15:47, Tilli, Juha-Matti (Nokia - FI/Espoo) < juha-matti.tilli@nokia.com> wrote: > Hi, > > > > If you have verified that there is no tab, it might be a technical problem > with my Outlook. > > > > The problem I’m seeing is this subject line: > > > > [lng-odp] [API-NEXT PATCH 2/5] linux-generic: drv: creation of > the driver interface (drv) > > > > …where there appears to be multiple spaces in the subject, but if you > select it with the mouse, you see it’s actually a tab and not multiple > spaces. Not sure where that’s coming from. I assumed that the original > patch contains a tab there, but there might be multiple explanations. > Outlook is after all not the best possible e-mail client. > > > > *From:* EXT Christophe Milard [mailto:christophe.milard@linaro.org] > *Sent:* Friday, February 12, 2016 4:25 PM > *To:* Tilli, Juha-Matti (Nokia - FI/Espoo) > *Cc:* anders.roxell@linaro.org; mike.holmes@linaro.org; > bill.fischofer@linaro.org; petri.savolainen@linaro.org; > lng-odp@lists.linaro.org > *Subject:* Re: [lng-odp] [API-NEXT PATCH 1/5] drv: creation of the driver > interface (drv) > > > > > > > > On 12 February 2016 at 15:16, Tilli, Juha-Matti (Nokia - FI/Espoo) < > juha-matti.tilli@nokia.com> wrote: > > Hi, > > Is there a tabulator in the first line of the commit message (i.e. in the > email subject)? If so, I would remove it and replace with a space. Applies > to many other patches in this series, as well. > > > > Sorry: I cannot see any tab. at least where I am looking for... What > problem are you seeing exactly? > > > > Christophe. > > > -----Original Message----- > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of EXT > Christophe Milard > Sent: Friday, February 12, 2016 5:10 PM > To: anders.roxell@linaro.org; mike.holmes@linaro.org; > bill.fischofer@linaro.org; petri.savolainen@linaro.org > Cc: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCH 1/5] drv: creation of the driver > interface (drv) > > The Driver Programming Interface (drv) is defined in include/odp_drv.h and > include/odp/drv/spec directory. > > Signed-off-by: Christophe Milard <christophe.milard@linaro.org> > --- > include/odp/drv/spec/README | 4 ++++ > include/odp_drv.h | 24 ++++++++++++++++++++++++ > 2 files changed, 28 insertions(+) > create mode 100644 include/odp/drv/spec/README > create mode 100644 include/odp_drv.h > > diff --git a/include/odp/drv/spec/README b/include/odp/drv/spec/README > new file mode 100644 > index 0000000..cd017bf > --- /dev/null > +++ b/include/odp/drv/spec/README > @@ -0,0 +1,4 @@ > +This directory should contain files (including doxygen documentation) > defining > +the ODP Nic driver interface. > +The NIC driver interface is the south interface of ODP, which is used by > +PCI nic drivers. > diff --git a/include/odp_drv.h b/include/odp_drv.h > new file mode 100644 > index 0000000..b78fa9d > --- /dev/null > +++ b/include/odp_drv.h > @@ -0,0 +1,24 @@ > +/* Copyright (c) 2016, Linaro Limited > + * All rights reserved > + * > + * SPDX-License-Identifier: BSD-3-Clause > + */ > + > +/** > + * @file > + * > + * The OpenDataPlane nic driver programming interface > + * > + */ > + > +#ifndef ODP_DRV_H_ > +#define ODP_DRV_H_ > + > +#ifdef __cplusplus > +extern C { > +#endif > + > +#ifdef __cplusplus > +} > +#endif > +#endif > -- > 2.1.4 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp > > >
It looks ok to me in gmail if that helps On 12 February 2016 at 10:25, Christophe Milard < christophe.milard@linaro.org> wrote: > I cannot see any strange character in this. If anyone see the same, or can > understand this problem, please let me know. > Christophe. > > On 12 February 2016 at 15:47, Tilli, Juha-Matti (Nokia - FI/Espoo) < > juha-matti.tilli@nokia.com> wrote: > >> Hi, >> >> >> >> If you have verified that there is no tab, it might be a technical >> problem with my Outlook. >> >> >> >> The problem I’m seeing is this subject line: >> >> >> >> [lng-odp] [API-NEXT PATCH 2/5] linux-generic: drv: creation of >> the driver interface (drv) >> >> >> >> …where there appears to be multiple spaces in the subject, but if you >> select it with the mouse, you see it’s actually a tab and not multiple >> spaces. Not sure where that’s coming from. I assumed that the original >> patch contains a tab there, but there might be multiple explanations. >> Outlook is after all not the best possible e-mail client. >> >> >> >> *From:* EXT Christophe Milard [mailto:christophe.milard@linaro.org] >> *Sent:* Friday, February 12, 2016 4:25 PM >> *To:* Tilli, Juha-Matti (Nokia - FI/Espoo) >> *Cc:* anders.roxell@linaro.org; mike.holmes@linaro.org; >> bill.fischofer@linaro.org; petri.savolainen@linaro.org; >> lng-odp@lists.linaro.org >> *Subject:* Re: [lng-odp] [API-NEXT PATCH 1/5] drv: creation of the >> driver interface (drv) >> >> >> >> >> >> >> >> On 12 February 2016 at 15:16, Tilli, Juha-Matti (Nokia - FI/Espoo) < >> juha-matti.tilli@nokia.com> wrote: >> >> Hi, >> >> Is there a tabulator in the first line of the commit message (i.e. in the >> email subject)? If so, I would remove it and replace with a space. Applies >> to many other patches in this series, as well. >> >> >> >> Sorry: I cannot see any tab. at least where I am looking for... What >> problem are you seeing exactly? >> >> >> >> Christophe. >> >> >> -----Original Message----- >> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of EXT >> Christophe Milard >> Sent: Friday, February 12, 2016 5:10 PM >> To: anders.roxell@linaro.org; mike.holmes@linaro.org; >> bill.fischofer@linaro.org; petri.savolainen@linaro.org >> Cc: lng-odp@lists.linaro.org >> Subject: [lng-odp] [API-NEXT PATCH 1/5] drv: creation of the driver >> interface (drv) >> >> The Driver Programming Interface (drv) is defined in include/odp_drv.h and >> include/odp/drv/spec directory. >> >> Signed-off-by: Christophe Milard <christophe.milard@linaro.org> >> --- >> include/odp/drv/spec/README | 4 ++++ >> include/odp_drv.h | 24 ++++++++++++++++++++++++ >> 2 files changed, 28 insertions(+) >> create mode 100644 include/odp/drv/spec/README >> create mode 100644 include/odp_drv.h >> >> diff --git a/include/odp/drv/spec/README b/include/odp/drv/spec/README >> new file mode 100644 >> index 0000000..cd017bf >> --- /dev/null >> +++ b/include/odp/drv/spec/README >> @@ -0,0 +1,4 @@ >> +This directory should contain files (including doxygen documentation) >> defining >> +the ODP Nic driver interface. >> +The NIC driver interface is the south interface of ODP, which is used by >> +PCI nic drivers. >> diff --git a/include/odp_drv.h b/include/odp_drv.h >> new file mode 100644 >> index 0000000..b78fa9d >> --- /dev/null >> +++ b/include/odp_drv.h >> @@ -0,0 +1,24 @@ >> +/* Copyright (c) 2016, Linaro Limited >> + * All rights reserved >> + * >> + * SPDX-License-Identifier: BSD-3-Clause >> + */ >> + >> +/** >> + * @file >> + * >> + * The OpenDataPlane nic driver programming interface >> + * >> + */ >> + >> +#ifndef ODP_DRV_H_ >> +#define ODP_DRV_H_ >> + >> +#ifdef __cplusplus >> +extern C { >> +#endif >> + >> +#ifdef __cplusplus >> +} >> +#endif >> +#endif >> -- >> 2.1.4 >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp >> >> >> > > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collborative, the rest follows"
Juha wrote that he sees the problem on other patches as well. so probably an outlook issue. I have dumped the series from gmail and mutt and could not find anything wrong. Juha will come back to me if it turns out to be a patch problem, but as it looks now, it feels the problem lies on his side. thanks for looking at it. Christophe. On 12 February 2016 at 16:36, Mike Holmes <mike.holmes@linaro.org> wrote: > It looks ok to me in gmail if that helps > > On 12 February 2016 at 10:25, Christophe Milard < > christophe.milard@linaro.org> wrote: > >> I cannot see any strange character in this. If anyone see the same, or >> can understand this problem, please let me know. >> Christophe. >> >> On 12 February 2016 at 15:47, Tilli, Juha-Matti (Nokia - FI/Espoo) < >> juha-matti.tilli@nokia.com> wrote: >> >>> Hi, >>> >>> >>> >>> If you have verified that there is no tab, it might be a technical >>> problem with my Outlook. >>> >>> >>> >>> The problem I’m seeing is this subject line: >>> >>> >>> >>> [lng-odp] [API-NEXT PATCH 2/5] linux-generic: drv: creation of >>> the driver interface (drv) >>> >>> >>> >>> …where there appears to be multiple spaces in the subject, but if you >>> select it with the mouse, you see it’s actually a tab and not multiple >>> spaces. Not sure where that’s coming from. I assumed that the original >>> patch contains a tab there, but there might be multiple explanations. >>> Outlook is after all not the best possible e-mail client. >>> >>> >>> >>> *From:* EXT Christophe Milard [mailto:christophe.milard@linaro.org] >>> *Sent:* Friday, February 12, 2016 4:25 PM >>> *To:* Tilli, Juha-Matti (Nokia - FI/Espoo) >>> *Cc:* anders.roxell@linaro.org; mike.holmes@linaro.org; >>> bill.fischofer@linaro.org; petri.savolainen@linaro.org; >>> lng-odp@lists.linaro.org >>> *Subject:* Re: [lng-odp] [API-NEXT PATCH 1/5] drv: creation of the >>> driver interface (drv) >>> >>> >>> >>> >>> >>> >>> >>> On 12 February 2016 at 15:16, Tilli, Juha-Matti (Nokia - FI/Espoo) < >>> juha-matti.tilli@nokia.com> wrote: >>> >>> Hi, >>> >>> Is there a tabulator in the first line of the commit message (i.e. in >>> the email subject)? If so, I would remove it and replace with a space. >>> Applies to many other patches in this series, as well. >>> >>> >>> >>> Sorry: I cannot see any tab. at least where I am looking for... What >>> problem are you seeing exactly? >>> >>> >>> >>> Christophe. >>> >>> >>> -----Original Message----- >>> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of >>> EXT Christophe Milard >>> Sent: Friday, February 12, 2016 5:10 PM >>> To: anders.roxell@linaro.org; mike.holmes@linaro.org; >>> bill.fischofer@linaro.org; petri.savolainen@linaro.org >>> Cc: lng-odp@lists.linaro.org >>> Subject: [lng-odp] [API-NEXT PATCH 1/5] drv: creation of the driver >>> interface (drv) >>> >>> The Driver Programming Interface (drv) is defined in include/odp_drv.h >>> and >>> include/odp/drv/spec directory. >>> >>> Signed-off-by: Christophe Milard <christophe.milard@linaro.org> >>> --- >>> include/odp/drv/spec/README | 4 ++++ >>> include/odp_drv.h | 24 ++++++++++++++++++++++++ >>> 2 files changed, 28 insertions(+) >>> create mode 100644 include/odp/drv/spec/README >>> create mode 100644 include/odp_drv.h >>> >>> diff --git a/include/odp/drv/spec/README b/include/odp/drv/spec/README >>> new file mode 100644 >>> index 0000000..cd017bf >>> --- /dev/null >>> +++ b/include/odp/drv/spec/README >>> @@ -0,0 +1,4 @@ >>> +This directory should contain files (including doxygen documentation) >>> defining >>> +the ODP Nic driver interface. >>> +The NIC driver interface is the south interface of ODP, which is used by >>> +PCI nic drivers. >>> diff --git a/include/odp_drv.h b/include/odp_drv.h >>> new file mode 100644 >>> index 0000000..b78fa9d >>> --- /dev/null >>> +++ b/include/odp_drv.h >>> @@ -0,0 +1,24 @@ >>> +/* Copyright (c) 2016, Linaro Limited >>> + * All rights reserved >>> + * >>> + * SPDX-License-Identifier: BSD-3-Clause >>> + */ >>> + >>> +/** >>> + * @file >>> + * >>> + * The OpenDataPlane nic driver programming interface >>> + * >>> + */ >>> + >>> +#ifndef ODP_DRV_H_ >>> +#define ODP_DRV_H_ >>> + >>> +#ifdef __cplusplus >>> +extern C { >>> +#endif >>> + >>> +#ifdef __cplusplus >>> +} >>> +#endif >>> +#endif >>> -- >>> 2.1.4 >>> >>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org >>> https://lists.linaro.org/mailman/listinfo/lng-odp >>> >>> >>> >> >> > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs > "Work should be fun and collborative, the rest follows" > > >
diff --git a/include/odp/drv/spec/README b/include/odp/drv/spec/README new file mode 100644 index 0000000..cd017bf --- /dev/null +++ b/include/odp/drv/spec/README @@ -0,0 +1,4 @@ +This directory should contain files (including doxygen documentation) defining +the ODP Nic driver interface. +The NIC driver interface is the south interface of ODP, which is used by +PCI nic drivers. diff --git a/include/odp_drv.h b/include/odp_drv.h new file mode 100644 index 0000000..b78fa9d --- /dev/null +++ b/include/odp_drv.h @@ -0,0 +1,24 @@ +/* Copyright (c) 2016, Linaro Limited + * All rights reserved + * + * SPDX-License-Identifier: BSD-3-Clause + */ + +/** + * @file + * + * The OpenDataPlane nic driver programming interface + * + */ + +#ifndef ODP_DRV_H_ +#define ODP_DRV_H_ + +#ifdef __cplusplus +extern C { +#endif + +#ifdef __cplusplus +} +#endif +#endif
The Driver Programming Interface (drv) is defined in include/odp_drv.h and include/odp/drv/spec directory. Signed-off-by: Christophe Milard <christophe.milard@linaro.org> --- include/odp/drv/spec/README | 4 ++++ include/odp_drv.h | 24 ++++++++++++++++++++++++ 2 files changed, 28 insertions(+) create mode 100644 include/odp/drv/spec/README create mode 100644 include/odp_drv.h