| Message ID | 20221022004856.31984-1-inga.stotland@intel.com |
|---|---|
| State | Accepted |
| Commit | 3b1c7c00b8c22b3cb79532252c59eb0b287bb86d |
| Headers | show |
| Series | [v2] Bluetooth: MGMT: Fix error report for ADD_EXT_ADV_PARAMS | expand |
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Fri, 21 Oct 2022 17:48:56 -0700 you wrote: > When validating the parameter length for MGMT_OP_ADD_EXT_ADV_PARAMS > command, use the correct op code in error status report: > was MGMT_OP_ADD_ADVERTISING, changed to MGMT_OP_ADD_EXT_ADV_PARAMS. > > Fixes: 12410572833a2 ("Bluetooth: Break add adv into two mgmt commands") > Signed-off-by: Inga Stotland <inga.stotland@intel.com> > > [...] Here is the summary with links: - [v2] Bluetooth: MGMT: Fix error report for ADD_EXT_ADV_PARAMS https://git.kernel.org/bluetooth/bluetooth-next/c/28fd83db215e You are awesome, thank you!
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index a92e7e485feb..0dd30a3beb77 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -8859,7 +8859,7 @@ static int add_ext_adv_params(struct sock *sk, struct hci_dev *hdev, * extra parameters we don't know about will be ignored in this request. */ if (data_len < MGMT_ADD_EXT_ADV_PARAMS_MIN_SIZE) - return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_ADVERTISING, + return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_EXT_ADV_PARAMS, MGMT_STATUS_INVALID_PARAMS); flags = __le32_to_cpu(cp->flags);
When validating the parameter length for MGMT_OP_ADD_EXT_ADV_PARAMS command, use the correct op code in error status report: was MGMT_OP_ADD_ADVERTISING, changed to MGMT_OP_ADD_EXT_ADV_PARAMS. Fixes: 12410572833a2 ("Bluetooth: Break add adv into two mgmt commands") Signed-off-by: Inga Stotland <inga.stotland@intel.com> --- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)