diff mbox series

[1/1] dt-bindings: mmc: sdhci-of-dwcmhsc: Add reset support

Message ID 20221021171654.87071-1-sebastian.reichel@collabora.com
State Accepted
Commit 5cb7d23761c87cd490a59dc4bb0d618c92b711c5
Headers show
Series [1/1] dt-bindings: mmc: sdhci-of-dwcmhsc: Add reset support | expand

Commit Message

Sebastian Reichel Oct. 21, 2022, 5:16 p.m. UTC
Properly describe reset related properties in the binding.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 .../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml  | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Krzysztof Kozlowski Oct. 22, 2022, 4:06 p.m. UTC | #1
On 21/10/2022 13:16, Sebastian Reichel wrote:
> Properly describe reset related properties in the binding.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
>  .../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml  | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> index 71f8e726d641..162c1a4abf3c 100644
> --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> @@ -45,6 +45,18 @@ properties:
>        - const: block
>        - const: timer
>  
> +  resets:
> +    minItems: 5

No need for minItems, drop.

> +    maxItems: 5
> +
> +  reset-names:
> +    items:
> +      - const: core
> +      - const: bus
> +      - const: axi
> +      - const: block
> +      - const: timer
> +

The reset names have exactly the same names as clocks. Are these
responsible for some blocks on the device? Seems so... but I want to be
sure it wasn't copy-paste :)

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
index 71f8e726d641..162c1a4abf3c 100644
--- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
@@ -45,6 +45,18 @@  properties:
       - const: block
       - const: timer
 
+  resets:
+    minItems: 5
+    maxItems: 5
+
+  reset-names:
+    items:
+      - const: core
+      - const: bus
+      - const: axi
+      - const: block
+      - const: timer
+
   rockchip,txclk-tapnum:
     description: Specify the number of delay for tx sampling.
     $ref: /schemas/types.yaml#/definitions/uint8