| Message ID | 20221018103725.2580679-2-s.hauer@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/4] usb: chipidea: usbmisc_imx: Fix i.MX53 clock sel masks | expand |
On Tue, Oct 18, 2022 at 12:37:22PM +0200, Sascha Hauer wrote: > According to the reference manual the masks for the > MX53_USB_CTRL_1_H*_XCVR_CLK_SEL bits are 0x3, not 0x11 (which were > probably meant as 0b11). > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > Reviewed-by: Xu Yang <xu.yang_2@nxp.com> > Link: https://lore.kernel.org/r/20221011082924.884123-2-s.hauer@pengutronix.de > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > drivers/usb/chipidea/usbmisc_imx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) What commit id does this fix? Should it go to stable kernels? Same for all of the other patches in this series, please fix up with that information and resend. thanks, greg k-h
diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c index bac0f5458cab9..8f805aa9c383c 100644 --- a/drivers/usb/chipidea/usbmisc_imx.c +++ b/drivers/usb/chipidea/usbmisc_imx.c @@ -42,9 +42,9 @@ #define MX53_USB_OTG_PHY_CTRL_0_OFFSET 0x08 #define MX53_USB_OTG_PHY_CTRL_1_OFFSET 0x0c #define MX53_USB_CTRL_1_OFFSET 0x10 -#define MX53_USB_CTRL_1_H2_XCVR_CLK_SEL_MASK (0x11 << 2) +#define MX53_USB_CTRL_1_H2_XCVR_CLK_SEL_MASK (0x3 << 2) #define MX53_USB_CTRL_1_H2_XCVR_CLK_SEL_ULPI BIT(2) -#define MX53_USB_CTRL_1_H3_XCVR_CLK_SEL_MASK (0x11 << 6) +#define MX53_USB_CTRL_1_H3_XCVR_CLK_SEL_MASK (0x3 << 6) #define MX53_USB_CTRL_1_H3_XCVR_CLK_SEL_ULPI BIT(6) #define MX53_USB_UH2_CTRL_OFFSET 0x14 #define MX53_USB_UH3_CTRL_OFFSET 0x18