| Message ID | 20221017184338.64152-1-pmanank200502@gmail.com |
|---|---|
| State | Accepted |
| Commit | 8338b74a750c534c223e8943cc0ed0e198ece261 |
| Headers | show |
| Series | [v2] "ACPI: PCC: Fix unintentional integer overflow" | expand |
On Tue, Oct 18, 2022 at 3:13 AM lihuisong (C) <lihuisong@huawei.com> wrote: > > > 在 2022/10/18 2:43, Manank Patel 写道: > > Fixed unintentional u32 overflow by changing PCC_CMD_WAIT_RETRIES_NUM to 500ULL > > > > Fixes: 91cefefb6991 ("ACPI: PCC: replace wait_for_completion()") > > > > Signed-off-by: Manank Patel <pmanank200502@gmail.com> > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > > > > --- > > Thank you so much @sudeep for your clarifications! > > > > Changelog: > > v1->v2: > > Change the macro itself to ULL instead of typecasting in the > > code > > > > drivers/acpi/acpi_pcc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c > > index ee4ce5ba1fb2..3e252be047b8 100644 > > --- a/drivers/acpi/acpi_pcc.c > > +++ b/drivers/acpi/acpi_pcc.c > > @@ -27,7 +27,7 @@ > > * Arbitrary retries in case the remote processor is slow to respond > > * to PCC commands > > */ > > -#define PCC_CMD_WAIT_RETRIES_NUM 500 > > +#define PCC_CMD_WAIT_RETRIES_NUM 500ULL > > > > struct pcc_data { > > struct pcc_mbox_chan *pcc_chan; > > Acked-by: Huisong Li <lihuisong@huawei.com> Applied as 6.1-rc material, thanks!
diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c index ee4ce5ba1fb2..3e252be047b8 100644 --- a/drivers/acpi/acpi_pcc.c +++ b/drivers/acpi/acpi_pcc.c @@ -27,7 +27,7 @@ * Arbitrary retries in case the remote processor is slow to respond * to PCC commands */ -#define PCC_CMD_WAIT_RETRIES_NUM 500 +#define PCC_CMD_WAIT_RETRIES_NUM 500ULL struct pcc_data { struct pcc_mbox_chan *pcc_chan;
Fixed unintentional u32 overflow by changing PCC_CMD_WAIT_RETRIES_NUM to 500ULL Fixes: 91cefefb6991 ("ACPI: PCC: replace wait_for_completion()") Signed-off-by: Manank Patel <pmanank200502@gmail.com> Acked-by: Sudeep Holla <sudeep.holla@arm.com> --- Thank you so much @sudeep for your clarifications! Changelog: v1->v2: Change the macro itself to ULL instead of typecasting in the code drivers/acpi/acpi_pcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)