| Message ID | 20221013221242.218808-1-marex@denx.de |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/3] dt-bindings: mmc: arm,pl18x: Document interrupt-names is ignored | expand |
On Fri, 14 Oct 2022 00:12:40 +0200, Marek Vasut wrote: > Due to inconsistency of existing DTs regarding the content of this IP > interrupt-names DT property, document this such that interrupt-names > is not used by this IP bindings. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <andersson@kernel.org> > Cc: Konrad Dybcio <konrad.dybcio@somainline.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: Yann Gautier <yann.gautier@foss.st.com> > Cc: devicetree@vger.kernel.org > Cc: linux-mmc@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-stm32@st-md-mailman.stormreply.com > To: linux-arm-kernel@lists.infradead.org > --- > V2: Add deprecated:false to interrupts: description > --- > Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On 13/10/2022 18:12, Marek Vasut wrote: > Due to inconsistency of existing DTs regarding the content of this IP > interrupt-names DT property, document this such that interrupt-names > is not used by this IP bindings. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <andersson@kernel.org> > Cc: Konrad Dybcio <konrad.dybcio@somainline.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: Yann Gautier <yann.gautier@foss.st.com> > Cc: devicetree@vger.kernel.org > Cc: linux-mmc@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-stm32@st-md-mailman.stormreply.com > To: linux-arm-kernel@lists.infradead.org > --- > V2: Add deprecated:false to interrupts: description > --- > Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml > index 1e69a5a42439b..1c96da04f0e53 100644 > --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml > +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml > @@ -95,7 +95,9 @@ properties: > PIO (polled I/O) interrupt and occurs when the FIFO needs to be > emptied as part of a bulk read from the card. Some variants have these > two interrupts wired into the same line (logic OR) and in that case > - only one interrupt may be provided. > + only one interrupt may be provided. The interrupt-names property is > + not used due to inconsistency of existing DTs regarding its content. > + deprecated: false Why do you add deprecated false? All properties are not deprecated by default. Did any other referenced schema make it deprecated? Best regards, Krzysztof
On 10/14/22 18:01, Krzysztof Kozlowski wrote: > On 13/10/2022 18:12, Marek Vasut wrote: >> Due to inconsistency of existing DTs regarding the content of this IP >> interrupt-names DT property, document this such that interrupt-names >> is not used by this IP bindings. >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> --- >> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> >> Cc: Andy Gross <agross@kernel.org> >> Cc: Bjorn Andersson <andersson@kernel.org> >> Cc: Konrad Dybcio <konrad.dybcio@somainline.org> >> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Ulf Hansson <ulf.hansson@linaro.org> >> Cc: Yann Gautier <yann.gautier@foss.st.com> >> Cc: devicetree@vger.kernel.org >> Cc: linux-mmc@vger.kernel.org >> Cc: linux-arm-msm@vger.kernel.org >> Cc: linux-stm32@st-md-mailman.stormreply.com >> To: linux-arm-kernel@lists.infradead.org >> --- >> V2: Add deprecated:false to interrupts: description >> --- >> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml >> index 1e69a5a42439b..1c96da04f0e53 100644 >> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml >> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml >> @@ -95,7 +95,9 @@ properties: >> PIO (polled I/O) interrupt and occurs when the FIFO needs to be >> emptied as part of a bulk read from the card. Some variants have these >> two interrupts wired into the same line (logic OR) and in that case >> - only one interrupt may be provided. >> + only one interrupt may be provided. The interrupt-names property is >> + not used due to inconsistency of existing DTs regarding its content. >> + deprecated: false > > Why do you add deprecated false? All properties are not deprecated by > default. Did any other referenced schema make it deprecated? Rob asked me to add it in V1 .
On 14/10/2022 12:02, Marek Vasut wrote: >>> --- >>> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml >>> index 1e69a5a42439b..1c96da04f0e53 100644 >>> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml >>> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml >>> @@ -95,7 +95,9 @@ properties: >>> PIO (polled I/O) interrupt and occurs when the FIFO needs to be >>> emptied as part of a bulk read from the card. Some variants have these >>> two interrupts wired into the same line (logic OR) and in that case >>> - only one interrupt may be provided. >>> + only one interrupt may be provided. The interrupt-names property is >>> + not used due to inconsistency of existing DTs regarding its content. >>> + deprecated: false >> >> Why do you add deprecated false? All properties are not deprecated by >> default. Did any other referenced schema make it deprecated? > > Rob asked me to add it in V1 . Indeed, thanks. Best regards, Krzysztof
On Fri, 14 Oct 2022 at 00:13, Marek Vasut <marex@denx.de> wrote: > > Due to inconsistency of existing DTs regarding the content of this IP > interrupt-names DT property, document this such that interrupt-names > is not used by this IP bindings. > > Signed-off-by: Marek Vasut <marex@denx.de> Applied for next, thanks! Kind regards Uffe > --- > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <andersson@kernel.org> > Cc: Konrad Dybcio <konrad.dybcio@somainline.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: Yann Gautier <yann.gautier@foss.st.com> > Cc: devicetree@vger.kernel.org > Cc: linux-mmc@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-stm32@st-md-mailman.stormreply.com > To: linux-arm-kernel@lists.infradead.org > --- > V2: Add deprecated:false to interrupts: description > --- > Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml > index 1e69a5a42439b..1c96da04f0e53 100644 > --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml > +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml > @@ -95,7 +95,9 @@ properties: > PIO (polled I/O) interrupt and occurs when the FIFO needs to be > emptied as part of a bulk read from the card. Some variants have these > two interrupts wired into the same line (logic OR) and in that case > - only one interrupt may be provided. > + only one interrupt may be provided. The interrupt-names property is > + not used due to inconsistency of existing DTs regarding its content. > + deprecated: false > minItems: 1 > maxItems: 2 > > -- > 2.35.1 >
On Fri, 14 Oct 2022 00:12:40 +0200, Marek Vasut wrote: > Due to inconsistency of existing DTs regarding the content of this IP > interrupt-names DT property, document this such that interrupt-names > is not used by this IP bindings. > > Applied, thanks! [2/3] ARM: dts: qcom: Drop MMCI interrupt-names commit: 2f7fa366bac9aa2addb83ffa5f208291f4dbe4d8 Best regards,
diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml index 1e69a5a42439b..1c96da04f0e53 100644 --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml @@ -95,7 +95,9 @@ properties: PIO (polled I/O) interrupt and occurs when the FIFO needs to be emptied as part of a bulk read from the card. Some variants have these two interrupts wired into the same line (logic OR) and in that case - only one interrupt may be provided. + only one interrupt may be provided. The interrupt-names property is + not used due to inconsistency of existing DTs regarding its content. + deprecated: false minItems: 1 maxItems: 2
Due to inconsistency of existing DTs regarding the content of this IP interrupt-names DT property, document this such that interrupt-names is not used by this IP bindings. Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Andy Gross <agross@kernel.org> Cc: Bjorn Andersson <andersson@kernel.org> Cc: Konrad Dybcio <konrad.dybcio@somainline.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Ulf Hansson <ulf.hansson@linaro.org> Cc: Yann Gautier <yann.gautier@foss.st.com> Cc: devicetree@vger.kernel.org Cc: linux-mmc@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com To: linux-arm-kernel@lists.infradead.org --- V2: Add deprecated:false to interrupts: description --- Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)