| Message ID | 20221013215946.216184-2-marex@denx.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v6,1/2] gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock | expand |
On Fri, Oct 14, 2022 at 12:00 AM Marek Vasut <marex@denx.de> wrote: > Always configure GPIO pins which are used as interrupt source as INPUTs. > In case the default pin configuration is OUTPUT, or the prior stage does > configure the pins as OUTPUT, then Linux will not reconfigure the pin as > INPUT and no interrupts are received. > > Always configure the interrupt source GPIO pin as input to fix the above case. > > Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform") > Signed-off-by: Marek Vasut <marex@denx.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On 10/17/22 12:24, Linus Walleij wrote: > On Fri, Oct 14, 2022 at 12:00 AM Marek Vasut <marex@denx.de> wrote: > >> Always configure GPIO pins which are used as interrupt source as INPUTs. >> In case the default pin configuration is OUTPUT, or the prior stage does >> configure the pins as OUTPUT, then Linux will not reconfigure the pin as >> INPUT and no interrupts are received. >> >> Always configure the interrupt source GPIO pin as input to fix the above case. >> >> Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform") >> Signed-off-by: Marek Vasut <marex@denx.de> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Can you please just pick these two patches up ? Thank you
On Fri, Dec 16, 2022 at 10:51 PM Marek Vasut <marex@denx.de> wrote: > On 10/17/22 12:24, Linus Walleij wrote: > > On Fri, Oct 14, 2022 at 12:00 AM Marek Vasut <marex@denx.de> wrote: > > > >> Always configure GPIO pins which are used as interrupt source as INPUTs. > >> In case the default pin configuration is OUTPUT, or the prior stage does > >> configure the pins as OUTPUT, then Linux will not reconfigure the pin as > >> INPUT and no interrupts are received. > >> > >> Always configure the interrupt source GPIO pin as input to fix the above case. > >> > >> Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform") > >> Signed-off-by: Marek Vasut <marex@denx.de> > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Can you please just pick these two patches up ? Bartosz is queueing GPIO patches, I'm sure he will get to queue them soon enough. Yours, Linus Walleij
On 12/19/22 00:21, Linus Walleij wrote: > On Fri, Dec 16, 2022 at 10:51 PM Marek Vasut <marex@denx.de> wrote: >> On 10/17/22 12:24, Linus Walleij wrote: >>> On Fri, Oct 14, 2022 at 12:00 AM Marek Vasut <marex@denx.de> wrote: >>> >>>> Always configure GPIO pins which are used as interrupt source as INPUTs. >>>> In case the default pin configuration is OUTPUT, or the prior stage does >>>> configure the pins as OUTPUT, then Linux will not reconfigure the pin as >>>> INPUT and no interrupts are received. >>>> >>>> Always configure the interrupt source GPIO pin as input to fix the above case. >>>> >>>> Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform") >>>> Signed-off-by: Marek Vasut <marex@denx.de> >>> >>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >> >> Can you please just pick these two patches up ? > > Bartosz is queueing GPIO patches, I'm sure he will get to > queue them soon enough. Thanks
On 12/19/22 00:21, Linus Walleij wrote: > On Fri, Dec 16, 2022 at 10:51 PM Marek Vasut <marex@denx.de> wrote: >> On 10/17/22 12:24, Linus Walleij wrote: >>> On Fri, Oct 14, 2022 at 12:00 AM Marek Vasut <marex@denx.de> wrote: >>> >>>> Always configure GPIO pins which are used as interrupt source as INPUTs. >>>> In case the default pin configuration is OUTPUT, or the prior stage does >>>> configure the pins as OUTPUT, then Linux will not reconfigure the pin as >>>> INPUT and no interrupts are received. >>>> >>>> Always configure the interrupt source GPIO pin as input to fix the above case. >>>> >>>> Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform") >>>> Signed-off-by: Marek Vasut <marex@denx.de> >>> >>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >> >> Can you please just pick these two patches up ? > > Bartosz is queueing GPIO patches, I'm sure he will get to > queue them soon enough. Bartosz, any news ?
On Tue, Jan 10, 2023 at 9:16 AM Marek Vasut <marex@denx.de> wrote: > > On 12/19/22 00:21, Linus Walleij wrote: > > On Fri, Dec 16, 2022 at 10:51 PM Marek Vasut <marex@denx.de> wrote: > >> On 10/17/22 12:24, Linus Walleij wrote: > >>> On Fri, Oct 14, 2022 at 12:00 AM Marek Vasut <marex@denx.de> wrote: > >>> > >>>> Always configure GPIO pins which are used as interrupt source as INPUTs. > >>>> In case the default pin configuration is OUTPUT, or the prior stage does > >>>> configure the pins as OUTPUT, then Linux will not reconfigure the pin as > >>>> INPUT and no interrupts are received. > >>>> > >>>> Always configure the interrupt source GPIO pin as input to fix the above case. > >>>> > >>>> Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform") > >>>> Signed-off-by: Marek Vasut <marex@denx.de> > >>> > >>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > >> > >> Can you please just pick these two patches up ? > > > > Bartosz is queueing GPIO patches, I'm sure he will get to > > queue them soon enough. > > Bartosz, any news ? I don't know why this has escaped my attention for so long. I wanted to apply it but it no longer applies on top of my for-next branch. Could you rebase and resend? Sorry for the trouble Marek. Bart
On 1/16/23 09:31, Bartosz Golaszewski wrote: > On Tue, Jan 10, 2023 at 9:16 AM Marek Vasut <marex@denx.de> wrote: >> >> On 12/19/22 00:21, Linus Walleij wrote: >>> On Fri, Dec 16, 2022 at 10:51 PM Marek Vasut <marex@denx.de> wrote: >>>> On 10/17/22 12:24, Linus Walleij wrote: >>>>> On Fri, Oct 14, 2022 at 12:00 AM Marek Vasut <marex@denx.de> wrote: >>>>> >>>>>> Always configure GPIO pins which are used as interrupt source as INPUTs. >>>>>> In case the default pin configuration is OUTPUT, or the prior stage does >>>>>> configure the pins as OUTPUT, then Linux will not reconfigure the pin as >>>>>> INPUT and no interrupts are received. >>>>>> >>>>>> Always configure the interrupt source GPIO pin as input to fix the above case. >>>>>> >>>>>> Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform") >>>>>> Signed-off-by: Marek Vasut <marex@denx.de> >>>>> >>>>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >>>> >>>> Can you please just pick these two patches up ? >>> >>> Bartosz is queueing GPIO patches, I'm sure he will get to >>> queue them soon enough. >> >> Bartosz, any news ? > > I don't know why this has escaped my attention for so long. I wanted > to apply it but it no longer applies on top of my for-next branch. > Could you rebase and resend? Sorry for the trouble Marek. Done, V7 is out.
diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c index 6cc98a5684ae1..dd91908c72f19 100644 --- a/drivers/gpio/gpio-mxc.c +++ b/drivers/gpio/gpio-mxc.c @@ -210,7 +210,7 @@ static int gpio_set_irq_type(struct irq_data *d, u32 type) raw_spin_unlock_irqrestore(&port->gc.bgpio_lock, flags); - return 0; + return port->gc.direction_input(&port->gc, gpio_idx); } static void mxc_flip_edge(struct mxc_gpio_port *port, u32 gpio)
Always configure GPIO pins which are used as interrupt source as INPUTs. In case the default pin configuration is OUTPUT, or the prior stage does configure the pins as OUTPUT, then Linux will not reconfigure the pin as INPUT and no interrupts are received. Always configure the interrupt source GPIO pin as input to fix the above case. Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform") Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Loic Poulain <loic.poulain@linaro.org> Cc: Marc Zyngier <maz@kernel.org> Cc: NXP Linux Team <linux-imx@nxp.com> Cc: Peng Fan <peng.fan@nxp.com> Cc: Shawn Guo <shawnguo@kernel.org> --- V2: Actually update and clear bits in GDIR register V3: Rebase on top of new patch 1/2, expand CC list, add Fixes tag V4: No change V5: No change V6: - Call gc->direction_input() to set direction, instead of GDIR register poking. The bgpio (gpio-mmio) may cache the content of direction register, so updating the HW GDIR register is not enough. Calling the gc->direction() assures the cache is updated. - Drop RBs since this is updated patch. --- drivers/gpio/gpio-mxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)