| Message ID | YzhVIaNGdM33pcts@octinomon |
|---|---|
| State | New |
| Headers | show |
| Series | usbip: vudc: Convert snprintf() to sysfs_emit() | expand |
On 10/1/22 08:56, Jules Irenge wrote: > Coccinnelle reports a warning > Warning: Use scnprintf or sprintf > > Following the advice on kernel documentation > https://www.kernel.org/doc/html/latest/filesystems/sysfs.html > > For show(device *...) functions we should only use sysfs_emit() or sysfs_emit_at() > especially when formatting the value to be returned to user space. > Convert snprintf() to sysfs_emit() > > Signed-off-by: Jules Irenge <jules.irenge@postgrad.manchester.ac.uk> > --- > drivers/usb/usbip/vudc_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c > index c95e6b2bfd32..907a43a00896 100644 > --- a/drivers/usb/usbip/vudc_sysfs.c > +++ b/drivers/usb/usbip/vudc_sysfs.c > @@ -242,7 +242,7 @@ static ssize_t usbip_status_show(struct device *dev, > status = udc->ud.status; > spin_unlock_irq(&udc->ud.lock); > > - return snprintf(out, PAGE_SIZE, "%d\n", status); > + return sysfs_emit(out, "%d\n", status); > } > static DEVICE_ATTR_RO(usbip_status); > Looks good to me. Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> Greg, Please pick this up. thanks, -- Shuah
diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c index c95e6b2bfd32..907a43a00896 100644 --- a/drivers/usb/usbip/vudc_sysfs.c +++ b/drivers/usb/usbip/vudc_sysfs.c @@ -242,7 +242,7 @@ static ssize_t usbip_status_show(struct device *dev, status = udc->ud.status; spin_unlock_irq(&udc->ud.lock); - return snprintf(out, PAGE_SIZE, "%d\n", status); + return sysfs_emit(out, "%d\n", status); } static DEVICE_ATTR_RO(usbip_status);
Coccinnelle reports a warning Warning: Use scnprintf or sprintf Following the advice on kernel documentation https://www.kernel.org/doc/html/latest/filesystems/sysfs.html For show(device *...) functions we should only use sysfs_emit() or sysfs_emit_at() especially when formatting the value to be returned to user space. Convert snprintf() to sysfs_emit() Signed-off-by: Jules Irenge <jules.irenge@postgrad.manchester.ac.uk> --- drivers/usb/usbip/vudc_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)