diff mbox series

[1/4] Input: twl4030-pwrbutton - add missing of.h include

Message ID 20220927052217.2784593-1-dmitry.torokhov@gmail.com
State New
Headers show
Series [1/4] Input: twl4030-pwrbutton - add missing of.h include | expand

Commit Message

Dmitry Torokhov Sept. 27, 2022, 5:22 a.m. UTC
The driver is using of_match_ptr() and therefore needs to include
of.h header.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/misc/twl4030-pwrbutton.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Guenter Roeck Sept. 27, 2022, 10:55 a.m. UTC | #1
On 9/26/22 22:22, Dmitry Torokhov wrote:
> The driver is using of_device_id and therefore needs to include
> of.h header. We used to get this definition indirectly via inclusion
> of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h
> from unnecessary includes.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/twl4030_wdt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/twl4030_wdt.c b/drivers/watchdog/twl4030_wdt.c
> index 355e428c0b99..e715ac1369a0 100644
> --- a/drivers/watchdog/twl4030_wdt.c
> +++ b/drivers/watchdog/twl4030_wdt.c
> @@ -9,6 +9,7 @@
>   #include <linux/types.h>
>   #include <linux/slab.h>
>   #include <linux/kernel.h>
> +#include <linux/of.h>
>   #include <linux/watchdog.h>
>   #include <linux/platform_device.h>
>   #include <linux/mfd/twl.h>
Andy Shevchenko Sept. 27, 2022, 12:24 p.m. UTC | #2
On Mon, Sep 26, 2022 at 10:22:16PM -0700, Dmitry Torokhov wrote:
> The driver is using of_device_id and therefore needs to include
> of.h header.

As per patch 2 comment, mod_devicetable.h is needed for that.

> We used to get this definition indirectly via inclusion
> of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h
> from unnecessary includes.
Dmitry Torokhov Sept. 27, 2022, 3:36 p.m. UTC | #3
On Tue, Sep 27, 2022 at 03:24:25PM +0300, Andy Shevchenko wrote:
> On Mon, Sep 26, 2022 at 10:22:16PM -0700, Dmitry Torokhov wrote:
> > The driver is using of_device_id and therefore needs to include
> > of.h header.
> 
> As per patch 2 comment, mod_devicetable.h is needed for that.

It also uses of_match_ptr(), so of.h is the one that is needed. I'll
adjust the patch description.

Thanks.
Mattijs Korpershoek Sept. 28, 2022, 6:48 a.m. UTC | #4
On Mon, Sep 26, 2022 at 22:22, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:

> The driver is using of_match_ptr() and therefore needs to include
> of.h header.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  drivers/input/misc/twl4030-pwrbutton.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
> index b307cca17022..e3ee0638ffba 100644
> --- a/drivers/input/misc/twl4030-pwrbutton.c
> +++ b/drivers/input/misc/twl4030-pwrbutton.c
> @@ -26,6 +26,7 @@
>  #include <linux/errno.h>
>  #include <linux/input.h>
>  #include <linux/interrupt.h>
> +#include <linux/of.h>
>  #include <linux/platform_device.h>
>  #include <linux/mfd/twl.h>
>  
> -- 
> 2.38.0.rc1.362.ged0d419d3c-goog
diff mbox series

Patch

diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
index b307cca17022..e3ee0638ffba 100644
--- a/drivers/input/misc/twl4030-pwrbutton.c
+++ b/drivers/input/misc/twl4030-pwrbutton.c
@@ -26,6 +26,7 @@ 
 #include <linux/errno.h>
 #include <linux/input.h>
 #include <linux/interrupt.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/mfd/twl.h>