diff mbox series

[v2,1/3] watchdog: twl4030_wdt: add missing mod_devicetable.h include

Message ID 20220927154611.3330871-1-dmitry.torokhov@gmail.com
State Superseded
Headers show
Series [v2,1/3] watchdog: twl4030_wdt: add missing mod_devicetable.h include | expand

Commit Message

Dmitry Torokhov Sept. 27, 2022, 3:46 p.m. UTC
The driver is using of_device_id and therefore needs to include
mod_devicetable.h header. We used to get this definition indirectly via
inclusion of matrix_keypad.h from twl.h, but we are cleaning up
matrix_keypad.h from unnecessary includes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

v2: changed from of.h to mod_devicetable.h per Andy Shevchenko

 drivers/watchdog/twl4030_wdt.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Guenter Roeck Sept. 28, 2022, 1:11 a.m. UTC | #1
On Tue, Sep 27, 2022 at 08:46:09AM -0700, Dmitry Torokhov wrote:
> The driver is using of_device_id and therefore needs to include
> mod_devicetable.h header. We used to get this definition indirectly via
> inclusion of matrix_keypad.h from twl.h, but we are cleaning up
> matrix_keypad.h from unnecessary includes.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> 
> v2: changed from of.h to mod_devicetable.h per Andy Shevchenko
> 
>  drivers/watchdog/twl4030_wdt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/twl4030_wdt.c b/drivers/watchdog/twl4030_wdt.c
> index 355e428c0b99..36b4a660928d 100644
> --- a/drivers/watchdog/twl4030_wdt.c
> +++ b/drivers/watchdog/twl4030_wdt.c
> @@ -9,6 +9,7 @@
>  #include <linux/types.h>
>  #include <linux/slab.h>
>  #include <linux/kernel.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/watchdog.h>
>  #include <linux/platform_device.h>
>  #include <linux/mfd/twl.h>
> -- 
> 2.38.0.rc1.362.ged0d419d3c-goog
>
Lee Jones Sept. 28, 2022, 3:14 p.m. UTC | #2
On Tue, 27 Sep 2022, Dmitry Torokhov wrote:

> The driver is using "struct device" and therefore needs to include
> device.h header. We used to get this definition indirectly via inclusion
> of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h
> from unnecessary includes.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> 
> v2: added Andy's reviewed-by
> 
>  drivers/mfd/twl4030-irq.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/watchdog/twl4030_wdt.c b/drivers/watchdog/twl4030_wdt.c
index 355e428c0b99..36b4a660928d 100644
--- a/drivers/watchdog/twl4030_wdt.c
+++ b/drivers/watchdog/twl4030_wdt.c
@@ -9,6 +9,7 @@ 
 #include <linux/types.h>
 #include <linux/slab.h>
 #include <linux/kernel.h>
+#include <linux/mod_devicetable.h>
 #include <linux/watchdog.h>
 #include <linux/platform_device.h>
 #include <linux/mfd/twl.h>