diff mbox series

[-next] usb: typec: fusb302: Switch to use dev_err_probe() helper

Message ID 20220922134806.2204579-1-yangyingliang@huawei.com
State New
Headers show
Series [-next] usb: typec: fusb302: Switch to use dev_err_probe() helper | expand

Commit Message

Yang Yingliang Sept. 22, 2022, 1:48 p.m. UTC
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/usb/typec/tcpm/fusb302.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Heikki Krogerus Sept. 22, 2022, 2:19 p.m. UTC | #1
On Thu, Sep 22, 2022 at 09:48:06PM +0800, Yang Yingliang wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tcpm/fusb302.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index db83b377b2f6..721b2a548084 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1743,9 +1743,8 @@ static int fusb302_probe(struct i2c_client *client,
>  	chip->tcpm_port = tcpm_register_port(&client->dev, &chip->tcpc_dev);
>  	if (IS_ERR(chip->tcpm_port)) {
>  		fwnode_handle_put(chip->tcpc_dev.fwnode);
> -		ret = PTR_ERR(chip->tcpm_port);
> -		if (ret != -EPROBE_DEFER)
> -			dev_err(dev, "cannot register tcpm port, ret=%d", ret);
> +		ret = dev_err_probe(dev, PTR_ERR(chip->tcpm_port),
> +				    "cannot register tcpm port\n");
>  		goto destroy_workqueue;
>  	}
>  
> -- 
> 2.25.1
Guenter Roeck Sept. 22, 2022, 2:42 p.m. UTC | #2
On 9/22/22 06:48, Yang Yingliang wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/usb/typec/tcpm/fusb302.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index db83b377b2f6..721b2a548084 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1743,9 +1743,8 @@ static int fusb302_probe(struct i2c_client *client,
>   	chip->tcpm_port = tcpm_register_port(&client->dev, &chip->tcpc_dev);
>   	if (IS_ERR(chip->tcpm_port)) {
>   		fwnode_handle_put(chip->tcpc_dev.fwnode);
> -		ret = PTR_ERR(chip->tcpm_port);
> -		if (ret != -EPROBE_DEFER)
> -			dev_err(dev, "cannot register tcpm port, ret=%d", ret);
> +		ret = dev_err_probe(dev, PTR_ERR(chip->tcpm_port),
> +				    "cannot register tcpm port\n");
>   		goto destroy_workqueue;
>   	}
>
diff mbox series

Patch

diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
index db83b377b2f6..721b2a548084 100644
--- a/drivers/usb/typec/tcpm/fusb302.c
+++ b/drivers/usb/typec/tcpm/fusb302.c
@@ -1743,9 +1743,8 @@  static int fusb302_probe(struct i2c_client *client,
 	chip->tcpm_port = tcpm_register_port(&client->dev, &chip->tcpc_dev);
 	if (IS_ERR(chip->tcpm_port)) {
 		fwnode_handle_put(chip->tcpc_dev.fwnode);
-		ret = PTR_ERR(chip->tcpm_port);
-		if (ret != -EPROBE_DEFER)
-			dev_err(dev, "cannot register tcpm port, ret=%d", ret);
+		ret = dev_err_probe(dev, PTR_ERR(chip->tcpm_port),
+				    "cannot register tcpm port\n");
 		goto destroy_workqueue;
 	}