| Message ID | 20220915113955.22521-3-astrid.rost@axis.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On 15/09/2022 12:39, Astrid Rost wrote: > Add devicetree parameters to control the insertion, release and press > debounce times. > Thank you for your patch. There is something to discuss/improve. > Signed-off-by: Astrid Rost <astrid.rost@axis.com> > --- > .../devicetree/bindings/sound/ts3a227e.yaml | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/ts3a227e.yaml b/Documentation/devicetree/bindings/sound/ts3a227e.yaml > index 3512b1f1e32b..8c27f298733a 100644 > --- a/Documentation/devicetree/bindings/sound/ts3a227e.yaml > +++ b/Documentation/devicetree/bindings/sound/ts3a227e.yaml > @@ -44,6 +44,35 @@ properties: > - 7 # 2.8 V > default: 2 > > + ti,debounce-release-ms: > + description: key release debounce time in ms (datasheet section 9.6.7). > + enum: > + - 0 # 0 ms (0) > + - 20 # 20 ms (1) Skip comments. The values are in ms, so they are not helping. Same in all other places. > + default: 20 Except that looks ok, thanks for the changes. Appreciated! Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/ts3a227e.yaml b/Documentation/devicetree/bindings/sound/ts3a227e.yaml index 3512b1f1e32b..8c27f298733a 100644 --- a/Documentation/devicetree/bindings/sound/ts3a227e.yaml +++ b/Documentation/devicetree/bindings/sound/ts3a227e.yaml @@ -44,6 +44,35 @@ properties: - 7 # 2.8 V default: 2 + ti,debounce-release-ms: + description: key release debounce time in ms (datasheet section 9.6.7). + enum: + - 0 # 0 ms (0) + - 20 # 20 ms (1) + default: 20 + + ti,debounce-press-ms: + description: key press debounce time in ms (datasheet section 9.6.7). + enum: + - 2 # 2 ms (0) + - 40 # 40 ms (1) + - 80 # 80 ms (2) + - 120 # 120 ms (3) + default: 80 + + ti,debounce-insertion-ms: + description: headset insertion debounce time in ms (datasheet section 9.6.5). + enum: + - 2 # 2 ms (0) + - 30 # 30 ms (1) + - 60 # 60 ms (2) + - 90 # 90 ms (3) + - 120 # 120 ms (4) + - 150 # 150 ms (5) + - 1000 # 1 s (6) + - 2000 # 2 s (7) + default: 90 + required: - compatible - reg
Add devicetree parameters to control the insertion, release and press debounce times. Signed-off-by: Astrid Rost <astrid.rost@axis.com> --- .../devicetree/bindings/sound/ts3a227e.yaml | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+)