| Message ID | 20220916133521.73183-1-prabhakar.mahadev-lad.rj@bp.renesas.com |
|---|---|
| State | New |
| Headers | show |
| Series | media: dt-bindings: i2c: ovti,ov5640: Drop ref to video-interface-devices.yaml | expand |
On 16/09/2022 14:35, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > video-interface-devices.yaml isn't used so just drop it from the > DT binding doc. Same question - the schema is used - you can see it with your own eyes, so please explain in commit msg what exactly is not used. Best regards, Krzysztof
Hi Prabhakar, Thank you for the patch. On Fri, Sep 16, 2022 at 02:35:21PM +0100, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > video-interface-devices.yaml isn't used so just drop it from the > DT binding doc. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml > index 540fd69ac39f..ce99aada75ad 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml > @@ -9,9 +9,6 @@ title: OmniVision OV5640 Image Sensor Device Tree Bindings > maintainers: > - Steve Longerbeam <slongerbeam@gmail.com> > > -allOf: > - - $ref: /schemas/media/video-interface-devices.yaml# > - The rotation property listed in this binding uses the definition from video-interface-devices.yaml. I don't think just dropping this is the right solution. Changing additionaProperties to unevaluatedProperties seems a better option. > properties: > compatible: > const: ovti,ov5640
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml index 540fd69ac39f..ce99aada75ad 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml @@ -9,9 +9,6 @@ title: OmniVision OV5640 Image Sensor Device Tree Bindings maintainers: - Steve Longerbeam <slongerbeam@gmail.com> -allOf: - - $ref: /schemas/media/video-interface-devices.yaml# - properties: compatible: const: ovti,ov5640