diff mbox series

[v2,5/6] acpi/x86: s2idle: Add a quirk for ASUS ROG Zephyrus G14

Message ID 20220912172401.22301-6-mario.limonciello@amd.com
State Superseded
Headers show
Series Fixups for s2idle on various Rembrandt laptops | expand

Commit Message

Mario Limonciello Sept. 12, 2022, 5:23 p.m. UTC
ASUS ROG Zephyrus G14 is affected by the same BIOS bug as ASUS TUF
Gaming A17 where important ASL is not called in the AMD code path.
Use the Microsoft codepath instead.

Reported-and-suggested-by: Philipp Zabel <philipp.zabel@gmail.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v1->v2:
 * New patch
---
 drivers/acpi/x86/s2idle.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Philipp Zabel Sept. 13, 2022, 4:50 p.m. UTC | #1
Am Mon, Sep 12, 2022 at 12:23:59PM -0500 schrieb Mario Limonciello:
> ASUS ROG Zephyrus G14 is affected by the same BIOS bug as ASUS TUF
> Gaming A17 where important ASL is not called in the AMD code path.
> Use the Microsoft codepath instead.
> 
> Reported-and-suggested-by: Philipp Zabel <philipp.zabel@gmail.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v1->v2:
>  * New patch
> ---
>  drivers/acpi/x86/s2idle.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
> index 9ee734e0c3c5..4bdc7133d2ea 100644
> --- a/drivers/acpi/x86/s2idle.c
> +++ b/drivers/acpi/x86/s2idle.c
> @@ -420,6 +420,14 @@ static const struct dmi_system_id s2idle_dmi_table[] __initconst = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "ASUS TUF Gaming A17"),
>  		},
>  	},
> +	{
> +		/* ASUS ROG Zephyrus G14 (2022) */
> +		.callback = lps0_prefer_microsoft,
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "ROG Zephyrus G14 GA402"),
> +		},
> +	},

Tested-by: Philipp Zabel <philipp.zabel@gmail.com>

regards
Philipp
Matthew Anderson Sept. 15, 2022, 3:22 a.m. UTC | #2
Tested and confirmed working on my Zephyus G14 laptop.

On 9/13/22 11:50 AM, Philipp Zabel wrote:
> Am Mon, Sep 12, 2022 at 12:23:59PM -0500 schrieb Mario Limonciello:
>> ASUS ROG Zephyrus G14 is affected by the same BIOS bug as ASUS TUF
>> Gaming A17 where important ASL is not called in the AMD code path.
>> Use the Microsoft codepath instead.
>>
>> Reported-and-suggested-by: Philipp Zabel <philipp.zabel@gmail.com>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> v1->v2:
>>   * New patch
>> ---
>>   drivers/acpi/x86/s2idle.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
>> index 9ee734e0c3c5..4bdc7133d2ea 100644
>> --- a/drivers/acpi/x86/s2idle.c
>> +++ b/drivers/acpi/x86/s2idle.c
>> @@ -420,6 +420,14 @@ static const struct dmi_system_id s2idle_dmi_table[] __initconst = {
>>   			DMI_MATCH(DMI_PRODUCT_NAME, "ASUS TUF Gaming A17"),
>>   		},
>>   	},
>> +	{
>> +		/* ASUS ROG Zephyrus G14 (2022) */
>> +		.callback = lps0_prefer_microsoft,
>> +		.matches = {
>> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>> +			DMI_MATCH(DMI_PRODUCT_NAME, "ROG Zephyrus G14 GA402"),
>> +		},
>> +	},
> Tested-by: Philipp Zabel <philipp.zabel@gmail.com>
>
> regards
> Philipp
>
>
Matthew Anderson Sept. 15, 2022, 3:48 a.m. UTC | #3
On 9/12/22 12:23 PM, Mario Limonciello wrote:
> ASUS ROG Zephyrus G14 is affected by the same BIOS bug as ASUS TUF
> Gaming A17 where important ASL is not called in the AMD code path.
> Use the Microsoft codepath instead.
>
> Reported-and-suggested-by: Philipp Zabel <philipp.zabel@gmail.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v1->v2:
>   * New patch
> ---
>   drivers/acpi/x86/s2idle.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
> index 9ee734e0c3c5..4bdc7133d2ea 100644
> --- a/drivers/acpi/x86/s2idle.c
> +++ b/drivers/acpi/x86/s2idle.c
> @@ -420,6 +420,14 @@ static const struct dmi_system_id s2idle_dmi_table[] __initconst = {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "ASUS TUF Gaming A17"),
>   		},
>   	},
> +	{
> +		/* ASUS ROG Zephyrus G14 (2022) */
> +		.callback = lps0_prefer_microsoft,
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "ROG Zephyrus G14 GA402"),
> +		},
> +	},
>   	{}
>   };
>   

Tested-by: Matthew Anderson <ruinairas1992@gmail.com>

Apologies for my troubles, I'm new to submitting to public emails.
diff mbox series

Patch

diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
index 9ee734e0c3c5..4bdc7133d2ea 100644
--- a/drivers/acpi/x86/s2idle.c
+++ b/drivers/acpi/x86/s2idle.c
@@ -420,6 +420,14 @@  static const struct dmi_system_id s2idle_dmi_table[] __initconst = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "ASUS TUF Gaming A17"),
 		},
 	},
+	{
+		/* ASUS ROG Zephyrus G14 (2022) */
+		.callback = lps0_prefer_microsoft,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "ROG Zephyrus G14 GA402"),
+		},
+	},
 	{}
 };