diff mbox series

tty: serial: qcom-geni-serial: Replace hardcoded icc flags with macros.

Message ID 1662564702-7253-1-git-send-email-quic_vnivarth@quicinc.com
State Accepted
Commit 408e532e80997be64caf8cdf45f2ff53c2279725
Headers show
Series tty: serial: qcom-geni-serial: Replace hardcoded icc flags with macros. | expand

Commit Message

Vijaya Krishna Nivarthi Sept. 7, 2022, 3:31 p.m. UTC 
In suspend/resume routines, icc flags are hardcoded.

Replace the hardcodes with macros available from header.

Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
---
 drivers/tty/serial/qcom_geni_serial.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Stephen Boyd Sept. 8, 2022, 12:43 a.m. UTC | #1 
Quoting Vijaya Krishna Nivarthi (2022-09-07 08:31:42)
> In suspend/resume routines, icc flags are hardcoded.
>
> Replace the hardcodes with macros available from header.
>
> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff mbox series

Patch

diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index 52182f6..83b66b7 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -22,6 +22,7 @@ 
 #include <linux/slab.h>
 #include <linux/tty.h>
 #include <linux/tty_flip.h>
+#include <dt-bindings/interconnect/qcom,icc.h>
 
 /* UART specific GENI registers */
 #define SE_UART_LOOPBACK_CFG		0x22c
@@ -1525,7 +1526,7 @@  static int __maybe_unused qcom_geni_serial_sys_suspend(struct device *dev)
 	 * even with no_console_suspend
 	 */
 	if (uart_console(uport)) {
-		geni_icc_set_tag(&port->se, 0x3);
+		geni_icc_set_tag(&port->se, QCOM_ICC_TAG_ACTIVE_ONLY);
 		geni_icc_set_bw(&port->se);
 	}
 	return uart_suspend_port(private_data->drv, uport);
@@ -1540,7 +1541,7 @@  static int __maybe_unused qcom_geni_serial_sys_resume(struct device *dev)
 
 	ret = uart_resume_port(private_data->drv, uport);
 	if (uart_console(uport)) {
-		geni_icc_set_tag(&port->se, 0x7);
+		geni_icc_set_tag(&port->se, QCOM_ICC_TAG_ALWAYS);
 		geni_icc_set_bw(&port->se);
 	}
 	return ret;