diff mbox series

ARM: dts: stm32mp15: remove hwlocks from pinctrl

Message ID 20220905091528.579610-1-etienne.carriere@linaro.org
State Accepted
Commit d6ff3c9f04f744345fe77a3d82c5b5e0c07c456a
Headers show
Series ARM: dts: stm32mp15: remove hwlocks from pinctrl | expand

Commit Message

Etienne Carriere Sept. 5, 2022, 9:15 a.m. UTC
Removes hwlocks properties from stm32mp151 pinctrl node. These locks
could be used for other purpose, depending on board and software
configuration hence do not enforce their use to protect pinctrl
devices.

This patch is an alignment with Linux device tree with v6.0 as the
hwsem support wasn’t yet added in pincontrol in kernel. It avoids
issues when the Linux kernel is started with the U-Boot device tree.

Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
---
 arch/arm/dts/stm32mp151.dtsi | 2 --
 1 file changed, 2 deletions(-)

Comments

Patrick DELAUNAY Sept. 6, 2022, 1:35 p.m. UTC | #1
Hi Etienne,

On 9/5/22 11:15, Etienne Carriere wrote:
> Removes hwlocks properties from stm32mp151 pinctrl node. These locks
> could be used for other purpose, depending on board and software
> configuration hence do not enforce their use to protect pinctrl
> devices.
>
> This patch is an alignment with Linux device tree with v6.0 as the
> hwsem support wasn’t yet added in pincontrol in kernel. It avoids
> issues when the Linux kernel is started with the U-Boot device tree.
>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> ---
>   arch/arm/dts/stm32mp151.dtsi | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/dts/stm32mp151.dtsi b/arch/arm/dts/stm32mp151.dtsi
> index a5ac62c83d..767a06ef68 100644
> --- a/arch/arm/dts/stm32mp151.dtsi
> +++ b/arch/arm/dts/stm32mp151.dtsi
> @@ -1663,7 +1663,6 @@
>   			ranges = <0 0x50002000 0xa400>;
>   			interrupt-parent = <&exti>;
>   			st,syscfg = <&exti 0x60 0xff>;
> -			hwlocks = <&hwspinlock 0>;
>   			pins-are-numbered;
>   
>   			gpioa: gpio@50002000 {
> @@ -1796,7 +1795,6 @@
>   			pins-are-numbered;
>   			interrupt-parent = <&exti>;
>   			st,syscfg = <&exti 0x60 0xff>;
> -			hwlocks = <&hwspinlock 0>;
>   
>   			gpioz: gpio@54004000 {
>   				gpio-controller;


Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick
Patrick DELAUNAY Sept. 7, 2022, 1:35 p.m. UTC | #2
Hi,

On 9/5/22 11:15, Etienne Carriere wrote:
> Removes hwlocks properties from stm32mp151 pinctrl node. These locks
> could be used for other purpose, depending on board and software
> configuration hence do not enforce their use to protect pinctrl
> devices.
>
> This patch is an alignment with Linux device tree with v6.0 as the
> hwsem support wasn’t yet added in pincontrol in kernel. It avoids
> issues when the Linux kernel is started with the U-Boot device tree.
>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> ---
>   arch/arm/dts/stm32mp151.dtsi | 2 --
>   1 file changed, 2 deletions(-)
>

Applied to u-boot-stm/master, thanks!


Regards
Patrick
diff mbox series

Patch

diff --git a/arch/arm/dts/stm32mp151.dtsi b/arch/arm/dts/stm32mp151.dtsi
index a5ac62c83d..767a06ef68 100644
--- a/arch/arm/dts/stm32mp151.dtsi
+++ b/arch/arm/dts/stm32mp151.dtsi
@@ -1663,7 +1663,6 @@ 
 			ranges = <0 0x50002000 0xa400>;
 			interrupt-parent = <&exti>;
 			st,syscfg = <&exti 0x60 0xff>;
-			hwlocks = <&hwspinlock 0>;
 			pins-are-numbered;
 
 			gpioa: gpio@50002000 {
@@ -1796,7 +1795,6 @@ 
 			pins-are-numbered;
 			interrupt-parent = <&exti>;
 			st,syscfg = <&exti 0x60 0xff>;
-			hwlocks = <&hwspinlock 0>;
 
 			gpioz: gpio@54004000 {
 				gpio-controller;