| Message ID | 20220903183753.25736-3-max@maxfierke.com |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce ClockworkPi CWD686 DRM panel driver | expand |
On 03/09/2022 21:37, Max Fierke wrote: > The CWD686 is a 6.86" IPS LCD panel used as the primary > display in the ClockworkPi DevTerm portable (all cores) > > Signed-off-by: Max Fierke <max@maxfierke.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Changes in v2 (Krzysztof Kozlowski and Rob Herring's Suggestions) > - remove redundant backlight example > - add missing regulators > > .../display/panel/clockworkpi,cwd686.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml b/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml > new file mode 100644 > index 000000000000..eaf55d629266 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/clockworkpi,cwd686.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ClockworkPi CWD686 6.86" IPS LCD panel > + > +maintainers: > + - Max Fierke <max@maxfierke.com> > + > +description: | > + The ClockworkPi CWD686 is a 6.86" ICNL9707-based IPS LCD panel used within the > + ClockworkPi DevTerm series of portable devices. The panel has a 480x1280 > + resolution and uses 24 bit RGB per pixel. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: clockworkpi,cwd686 > + > + reg: > + description: DSI virtual channel used by that screen > + maxItems: 1 You still need blank line here. > + iovcc-supply: > + description: regulator that supplies the iovcc voltage And here... > + vci-supply: > + description: regulator that supplies the vci voltage > + Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml b/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml new file mode 100644 index 000000000000..eaf55d629266 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/clockworkpi,cwd686.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ClockworkPi CWD686 6.86" IPS LCD panel + +maintainers: + - Max Fierke <max@maxfierke.com> + +description: | + The ClockworkPi CWD686 is a 6.86" ICNL9707-based IPS LCD panel used within the + ClockworkPi DevTerm series of portable devices. The panel has a 480x1280 + resolution and uses 24 bit RGB per pixel. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: clockworkpi,cwd686 + + reg: + description: DSI virtual channel used by that screen + maxItems: 1 + iovcc-supply: + description: regulator that supplies the iovcc voltage + vci-supply: + description: regulator that supplies the vci voltage + + reset-gpios: true + rotation: true + backlight: true + +required: + - compatible + - reg + - backlight + - reset-gpios + - iovcc-supply + - vci-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + dsi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "clockworkpi,cwd686"; + reg = <0>; + backlight = <&backlight>; + reset-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>; + rotation = <90>; + iovcc-supply = <&vcc_1v8>; + vci-supply = <&vcc3v3_sys>; + }; + };