diff mbox series

[v2,03/10] dt-bindings: misc: fastrpc: Document memory-region property

Message ID 20220902154900.3404524-4-abel.vesa@linaro.org
State New
Headers show
Series misc: fastrpc: Add audiopd support | expand

Commit Message

Abel Vesa Sept. 2, 2022, 3:48 p.m. UTC
Add memory-region property to the list of optional properties, specify
the value type and a definition

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 Documentation/devicetree/bindings/misc/qcom,fastrpc.txt | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski Sept. 4, 2022, 7:29 p.m. UTC | #1
On 02/09/2022 18:48, Abel Vesa wrote:
> Add memory-region property to the list of optional properties, specify
> the value type and a definition

You should write why adding this property. Is it already used?

New properties can go only to DT schema, so first the conversion [1]
should be finished or started from zero (9 months it's quite a time for
a resend...).

https://lore.kernel.org/all/20211208101508.24582-1-david@ixit.cz/


Best regards,
Krzysztof
Abel Vesa Sept. 5, 2022, 7:53 a.m. UTC | #2
On 22-09-04 22:29:04, Krzysztof Kozlowski wrote:
> On 02/09/2022 18:48, Abel Vesa wrote:
> > Add memory-region property to the list of optional properties, specify
> > the value type and a definition
> 
> You should write why adding this property. Is it already used?

It is not already used, will be used for cma remote heap. Will add it in
the next version.

> 
> New properties can go only to DT schema, so first the conversion [1]
> should be finished or started from zero (9 months it's quite a time for
> a resend...).
> 
> https://lore.kernel.org/all/20211208101508.24582-1-david@ixit.cz/

Right, will try to resend David's patch after addressing all the
remaining comments on that thread. Will be a separate patch.

> 
> 
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt b/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
index 5ec124b138a6..3dd02aaa7ba7 100644
--- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
+++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
@@ -17,6 +17,11 @@  other tasks.
 	Definition: should specify the dsp domain name this fastrpc
 	corresponds to. must be one of this: "adsp", "mdsp", "sdsp", "cdsp"
 
+- memory-region:
+	Usage: optional
+	Value type: <phandle>
+	Definition: reference to the reserved-memory for the region
+
 - qcom,non-secure-domain:
 	Usage: required
 	Value type: <boolean>