| Message ID | 20220829215816.6206-1-prabhakar.mahadev-lad.rj@bp.renesas.com |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: display: bridge: renesas,dw-hdmi: Fix 'unevaluatedProperties' warnings | expand |
Hi Laurent, On Tue, Aug 30, 2022 at 12:08 AM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Prabhakar, > > Thank you for the patch. > > On Mon, Aug 29, 2022 at 10:58:16PM +0100, Lad Prabhakar wrote: > > With 'unevaluatedProperties' support implemented, there's a number of > > warnings when running dtbs_check: > > > > arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex-idk-1110wr.dtb: hdmi@fead0000: Unevaluated properties are not allowed ('resets' was unexpected) > > From schema: Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml > > > > The main problem is that SoC DTSI's are including resets property, whereas > > the renesas,dw-hdmi.yaml has 'unevaluatedProperties: false'. So just add > > optional resets property to the binding. > > Given that all the DT sources in the kernel specify the resets property, > how about making it mandatory ? > Agreed, will do that and send a v2. Cheers, Prabhakar
diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml index 0c9785c8db51..a7e44e249dd3 100644 --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml @@ -38,6 +38,9 @@ properties: clock-names: maxItems: 2 + resets: + maxItems: 1 + ports: $ref: /schemas/graph.yaml#/properties/ports
With 'unevaluatedProperties' support implemented, there's a number of warnings when running dtbs_check: arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex-idk-1110wr.dtb: hdmi@fead0000: Unevaluated properties are not allowed ('resets' was unexpected) From schema: Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml The main problem is that SoC DTSI's are including resets property, whereas the renesas,dw-hdmi.yaml has 'unevaluatedProperties: false'. So just add optional resets property to the binding. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- .../devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml | 3 +++ 1 file changed, 3 insertions(+)