| Message ID | 20220829133923.1114555-1-martyn.welch@collabora.com |
|---|---|
| State | Accepted |
| Commit | ce0cb8fb967ec62ff000826fd469511ee2d3fcb2 |
| Headers | show |
| Series | [1/5] dt-bindings: vendor-prefixes: add Diodes | expand |
On 29/08/2022 16:39, Martyn Welch wrote: > Diodes Incorporated is a manufacturer of application specific standard > products within the discrete, logic, analog, and mixed-signal semiconductor > markets. > > https://www.diodes.com/ > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, Aug 30, 2022 at 9:50 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 29/08/2022 16:39, Martyn Welch wrote: > > The NXP PCAL6534 is a 34-bit I2C I/O expander similar to the PCAL6524. The > > Diodes PI4IOE5V6534Q is a functionally identical chip provided by Diodes > > Inc. > > > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > > Then diodes should be followed by fallback (and use only one compatible > to bind). Ugh I don't think we have done a very good job at providing fallbacks (several compatibles) for this hardware. Just looking at the list makes me suspicious. The fallback scheme is pretty hard to maintain when vendors are a bit unclear on whether things are really compatible or not, and sometimes they are compatible but rather not say :( Yours, Linus Walleij
On Wed, Aug 31, 2022 at 3:34 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > If you have specific+fallback compatible (e.g. diodes,pi4ioe5v6534q, > nxp,pcal6534), you can always introduce changes in the driver because it > will match to the specific one (diodes). You could even introduce > incompatible changes, if you insist, and the effect would be the same as > adding now two compatibles in the driver. I know, what I mean is that this binding should probably have fallback compatibles for the TI, Exar, Onnn and Maxim compatibles listed in the bindings, I bet they are all compatible with some nxp,pcaNNNN. We could fix that, perhaps. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 2f0151e9f6be..7ee9b7692ed1 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -328,6 +328,8 @@ patternProperties: description: Digi International Inc. "^digilent,.*": description: Diglent, Inc. + "^diodes,.*": + description: Diodes, Inc. "^dioo,.*": description: Dioo Microcircuit Co., Ltd "^dlc,.*":
Diodes Incorporated is a manufacturer of application specific standard products within the discrete, logic, analog, and mixed-signal semiconductor markets. https://www.diodes.com/ Signed-off-by: Martyn Welch <martyn.welch@collabora.com> --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)